We don't want to report inconsistencies when there are entities from different keyserver - only the ones from a keyserver performing state check should be compared.
Depends on D11182
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/shared/state-sync/threads-state-sync-spec.test.js | ||
|---|---|---|
| 174 ↗ | (On Diff #37648) | In earlier diffs we decided to use eg threadTypes.PRIVATE instead of literal for "readability" when pasting Redux state into unit tests. Don't feel strongly personally, but figure it makes sense to be consistent. |
| lib/shared/state-sync/entries-state-sync-spec.test.js | ||
|---|---|---|
| 56 ↗ | (On Diff #37648) | If we hardcode the current data into the entries but use defaultCalendarQuery here won't that mean that in a ~month we will just start filtering all entries and the tests will always pass? |
Comment Actions
Resigning so I won't block landing. I don't there should be any problems with fixing the tests.
Comment Actions
Use thread type const.
Update entries test by adding explicit calendar query from the past - the test failed as expected. Updated the dates in entries, which fixed the tests.
| lib/shared/state-sync/entries-state-sync-spec.test.js | ||
|---|---|---|
| 56 ↗ | (On Diff #37648) | Great find! Going to fix it |
| lib/shared/state-sync/threads-state-sync-spec.test.js | ||
| 174 ↗ | (On Diff #37648) | Makes sense! |