Page MenuHomePhabricator
Differential D11398

[native] expose farcaster id param to native identity service context provider
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 12:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 1:19 AM
Unknown Object (File)
Tue, Nov 12, 11:38 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 11 2024, 11:31 AM
View All 71 Files
Subscribers
tomek

Details

Reviewers
ashoat
bartek
Commits
rCOMMcbc627ce542e: [native] expose farcaster id param to native identity service context provider
Summary

Rust, C++ and js changes to add farcaster id param to the register methods in the native IdentityServiceContextProvider

Depends on D11396

Test Plan

called the js method and successfully registered an account with a farcaster ID. verified result in DDB.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 12:31 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 27 2024, 12:31 PM
varun added a child revision: D11399: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.Mar 27 2024, 12:36 PM
varun mentioned this in D11397: [native_rust_library] use farcaster id on register_wallet_user and register_password_user.Mar 27 2024, 12:37 PM
Harbormaster completed remote builds in B27713: Diff 38376.Mar 27 2024, 12:46 PM
varun requested review of this revision.Mar 27 2024, 12:46 PM
varun updated this revision to Diff 38395.Mar 27 2024, 1:44 PM
varun edited the summary of this revision. (Show Details)
varun edited the test plan for this revision. (Show Details)
varun added a reviewer: bartek.
varun added a parent revision: D11396: [proto][identity] add optional fid to registration request messages.

squash with D11397

varun updated this revision to Diff 38397.Mar 27 2024, 1:56 PM

remove TODOs. Here's the linear task, instead: https://linear.app/comm/issue/ENG-7588/replace-params-in-native-rust-library-methods-with-serialized-structs

Harbormaster failed remote builds in B27732: Diff 38395!Mar 27 2024, 2:06 PM
Harbormaster completed remote builds in B27734: Diff 38397.Mar 27 2024, 2:15 PM
varun added inline comments.Mar 27 2024, 3:22 PM
native/identity-service/identity-service-context-provider.react.js
320 ↗(On Diff #38397)

@ashoat will update this in the diff corresponding to commit d82e90b

ashoat accepted this revision.Mar 27 2024, 5:32 PM
bartek accepted this revision.Mar 27 2024, 10:24 PM
This revision is now accepted and ready to land.Mar 27 2024, 10:24 PM
Closed by commit rCOMMcbc627ce542e: [native] expose farcaster id param to native identity service context provider (authored by varun). · Explain WhyMar 28 2024, 2:55 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMcbc627ce542e: [native] expose farcaster id param to native identity service context provider.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
6 lines
10 lines
_generated/
identity-service/
2 lines
native_rust_library/
src/
7 lines
12 lines
9 lines
schema/
2 lines

Diff 38496

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/native_rust_library/src/farcaster.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/native_rust_library/src/wallet_registration.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...