Page MenuHomePhabricator
Differential D11423

[identity] unlink farcaster account RPC
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 4:50 PM.
Tags
None
Referenced Files
F5085252: D11423.diff
Sat, Mar 29, 4:00 PM
Unknown Object (File)
Feb 27 2025, 3:01 AM
Unknown Object (File)
Feb 18 2025, 7:06 PM
Unknown Object (File)
Feb 18 2025, 7:06 PM
Unknown Object (File)
Feb 18 2025, 7:06 PM
Unknown Object (File)
Feb 18 2025, 6:35 PM
Unknown Object (File)
Feb 6 2025, 3:10 AM
Unknown Object (File)
Jan 19 2025, 5:08 AM
View All 64 Files
Subscribers
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMM361377ad6c39: [identity] unlink farcaster account RPC
Summary
  • new RPC defined in auth.proto file
  • identity service implementation
  • db client method to remove the farcasterID attribute from DDB
  • grpc-web codegen updates

Depends on D11413

Test Plan
  1. added a farcaster ID to a user with the link RPC
  2. confirmed the ID appeared in DDB
  3. called the unlink RPC
  4. confirmed the ID no longer appeared in DDB
  5. called the unlink RPC again and it succeeded, but nothing changed in DDB, as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
20 lines
grpc_services/
16 lines
shared/
protos/
3 lines
web/
protobufs/
12 lines

Diff 38512

View Options

services/identity/src/database/farcaster.rs

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines try {
]); ]);
} catch {} } catch {}
const currentUserInfo = response ? loggedOutUserInfo : null; const currentUserInfo = response ? loggedOutUserInfo : null;
return { currentUserInfo, preRequestUserState, keyserverIDs }; return { currentUserInfo, preRequestUserState, keyserverIDs };
}; };
type UseLogOutOptions = { type UseLogOutOptions = {
+logOutType?: 'legacy' | 'primary_device' | 'secondary_device', +logOutType?: 'legacy' | 'primary_device' | 'secondary_device',
+skipIdentityLogOut?: boolean,
}; };
function useLogOut( function useLogOut(
options: UseLogOutOptions = {}, options: UseLogOutOptions = {},
): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> { ): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
const preRequestUserState = usePreRequestUserState(); const preRequestUserState = usePreRequestUserState();
const callKeyserverLogOut = useKeyserverCall(keyserverLogOut); const callKeyserverLogOut = useKeyserverCall(keyserverLogOut);
const commServicesAccessToken = useSelector( const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken, state => state.commServicesAccessToken,
); );
const { logOutType } = options; const { logOutType, skipIdentityLogOut } = options;
return React.useCallback( return React.useCallback(
async (keyserverIDs?: $ReadOnlyArray<string>) => { async (keyserverIDs?: $ReadOnlyArray<string>) => {
const identityPromise = (async () => { const identityPromise = (async () => {
if (!usingCommServicesAccessToken || !commServicesAccessToken) { if (
skipIdentityLogOut ||
!usingCommServicesAccessToken ||
!commServicesAccessToken
) {
return; return;
} }
if (!identityClient) { if (!identityClient) {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
let callIdentityClientLogOut; let callIdentityClientLogOut;
if (logOutType === 'primary_device') { if (logOutType === 'primary_device') {
if (!identityClient.logOutPrimaryDevice) { if (!identityClient.logOutPrimaryDevice) {
Show All 36 Lines async (keyserverIDs?: $ReadOnlyArray<string>) => {
}; };
}, },
[ [
callKeyserverLogOut, callKeyserverLogOut,
commServicesAccessToken, commServicesAccessToken,
identityClient, identityClient,
logOutType, logOutType,
preRequestUserState, preRequestUserState,
skipIdentityLogOut,
], ],
); );
} }
function useIdentityLogOut(): () => Promise<LogOutResult> { function useIdentityLogOut(): () => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
▲ Show 20 Lines • Show All 1,230 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_services/authenticated.rs

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines try {
]); ]);
} catch {} } catch {}
const currentUserInfo = response ? loggedOutUserInfo : null; const currentUserInfo = response ? loggedOutUserInfo : null;
return { currentUserInfo, preRequestUserState, keyserverIDs }; return { currentUserInfo, preRequestUserState, keyserverIDs };
}; };
type UseLogOutOptions = { type UseLogOutOptions = {
+logOutType?: 'legacy' | 'primary_device' | 'secondary_device', +logOutType?: 'legacy' | 'primary_device' | 'secondary_device',
+skipIdentityLogOut?: boolean,
}; };
function useLogOut( function useLogOut(
options: UseLogOutOptions = {}, options: UseLogOutOptions = {},
): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> { ): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
const preRequestUserState = usePreRequestUserState(); const preRequestUserState = usePreRequestUserState();
const callKeyserverLogOut = useKeyserverCall(keyserverLogOut); const callKeyserverLogOut = useKeyserverCall(keyserverLogOut);
const commServicesAccessToken = useSelector( const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken, state => state.commServicesAccessToken,
); );
const { logOutType } = options; const { logOutType, skipIdentityLogOut } = options;
return React.useCallback( return React.useCallback(
async (keyserverIDs?: $ReadOnlyArray<string>) => { async (keyserverIDs?: $ReadOnlyArray<string>) => {
const identityPromise = (async () => { const identityPromise = (async () => {
if (!usingCommServicesAccessToken || !commServicesAccessToken) { if (
skipIdentityLogOut ||
!usingCommServicesAccessToken ||
!commServicesAccessToken
) {
return; return;
} }
if (!identityClient) { if (!identityClient) {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
let callIdentityClientLogOut; let callIdentityClientLogOut;
if (logOutType === 'primary_device') { if (logOutType === 'primary_device') {
if (!identityClient.logOutPrimaryDevice) { if (!identityClient.logOutPrimaryDevice) {
Show All 36 Lines async (keyserverIDs?: $ReadOnlyArray<string>) => {
}; };
}, },
[ [
callKeyserverLogOut, callKeyserverLogOut,
commServicesAccessToken, commServicesAccessToken,
identityClient, identityClient,
logOutType, logOutType,
preRequestUserState, preRequestUserState,
skipIdentityLogOut,
], ],
); );
} }
function useIdentityLogOut(): () => Promise<LogOutResult> { function useIdentityLogOut(): () => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
▲ Show 20 Lines • Show All 1,230 Lines • Show Last 20 Lines
View Options

shared/protos/identity_auth.proto

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines try {
]); ]);
} catch {} } catch {}
const currentUserInfo = response ? loggedOutUserInfo : null; const currentUserInfo = response ? loggedOutUserInfo : null;
return { currentUserInfo, preRequestUserState, keyserverIDs }; return { currentUserInfo, preRequestUserState, keyserverIDs };
}; };
type UseLogOutOptions = { type UseLogOutOptions = {
+logOutType?: 'legacy' | 'primary_device' | 'secondary_device', +logOutType?: 'legacy' | 'primary_device' | 'secondary_device',
+skipIdentityLogOut?: boolean,
}; };
function useLogOut( function useLogOut(
options: UseLogOutOptions = {}, options: UseLogOutOptions = {},
): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> { ): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
const preRequestUserState = usePreRequestUserState(); const preRequestUserState = usePreRequestUserState();
const callKeyserverLogOut = useKeyserverCall(keyserverLogOut); const callKeyserverLogOut = useKeyserverCall(keyserverLogOut);
const commServicesAccessToken = useSelector( const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken, state => state.commServicesAccessToken,
); );
const { logOutType } = options; const { logOutType, skipIdentityLogOut } = options;
return React.useCallback( return React.useCallback(
async (keyserverIDs?: $ReadOnlyArray<string>) => { async (keyserverIDs?: $ReadOnlyArray<string>) => {
const identityPromise = (async () => { const identityPromise = (async () => {
if (!usingCommServicesAccessToken || !commServicesAccessToken) { if (
skipIdentityLogOut ||
!usingCommServicesAccessToken ||
!commServicesAccessToken
) {
return; return;
} }
if (!identityClient) { if (!identityClient) {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
let callIdentityClientLogOut; let callIdentityClientLogOut;
if (logOutType === 'primary_device') { if (logOutType === 'primary_device') {
if (!identityClient.logOutPrimaryDevice) { if (!identityClient.logOutPrimaryDevice) {
Show All 36 Lines async (keyserverIDs?: $ReadOnlyArray<string>) => {
}; };
}, },
[ [
callKeyserverLogOut, callKeyserverLogOut,
commServicesAccessToken, commServicesAccessToken,
identityClient, identityClient,
logOutType, logOutType,
preRequestUserState, preRequestUserState,
skipIdentityLogOut,
], ],
); );
} }
function useIdentityLogOut(): () => Promise<LogOutResult> { function useIdentityLogOut(): () => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
▲ Show 20 Lines • Show All 1,230 Lines • Show Last 20 Lines
View Options

web/protobufs/identity-auth-client.cjs

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines try {
]); ]);
} catch {} } catch {}
const currentUserInfo = response ? loggedOutUserInfo : null; const currentUserInfo = response ? loggedOutUserInfo : null;
return { currentUserInfo, preRequestUserState, keyserverIDs }; return { currentUserInfo, preRequestUserState, keyserverIDs };
}; };
type UseLogOutOptions = { type UseLogOutOptions = {
+logOutType?: 'legacy' | 'primary_device' | 'secondary_device', +logOutType?: 'legacy' | 'primary_device' | 'secondary_device',
+skipIdentityLogOut?: boolean,
}; };
function useLogOut( function useLogOut(
options: UseLogOutOptions = {}, options: UseLogOutOptions = {},
): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> { ): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
const preRequestUserState = usePreRequestUserState(); const preRequestUserState = usePreRequestUserState();
const callKeyserverLogOut = useKeyserverCall(keyserverLogOut); const callKeyserverLogOut = useKeyserverCall(keyserverLogOut);
const commServicesAccessToken = useSelector( const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken, state => state.commServicesAccessToken,
); );
const { logOutType } = options; const { logOutType, skipIdentityLogOut } = options;
return React.useCallback( return React.useCallback(
async (keyserverIDs?: $ReadOnlyArray<string>) => { async (keyserverIDs?: $ReadOnlyArray<string>) => {
const identityPromise = (async () => { const identityPromise = (async () => {
if (!usingCommServicesAccessToken || !commServicesAccessToken) { if (
skipIdentityLogOut ||
!usingCommServicesAccessToken ||
!commServicesAccessToken
) {
return; return;
} }
if (!identityClient) { if (!identityClient) {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
let callIdentityClientLogOut; let callIdentityClientLogOut;
if (logOutType === 'primary_device') { if (logOutType === 'primary_device') {
if (!identityClient.logOutPrimaryDevice) { if (!identityClient.logOutPrimaryDevice) {
Show All 36 Lines async (keyserverIDs?: $ReadOnlyArray<string>) => {
}; };
}, },
[ [
callKeyserverLogOut, callKeyserverLogOut,
commServicesAccessToken, commServicesAccessToken,
identityClient, identityClient,
logOutType, logOutType,
preRequestUserState, preRequestUserState,
skipIdentityLogOut,
], ],
); );
} }
function useIdentityLogOut(): () => Promise<LogOutResult> { function useIdentityLogOut(): () => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
▲ Show 20 Lines • Show All 1,230 Lines • Show Last 20 Lines
View Options

web/protobufs/identity-auth-client.cjs.flow

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines try {
]); ]);
} catch {} } catch {}
const currentUserInfo = response ? loggedOutUserInfo : null; const currentUserInfo = response ? loggedOutUserInfo : null;
return { currentUserInfo, preRequestUserState, keyserverIDs }; return { currentUserInfo, preRequestUserState, keyserverIDs };
}; };
type UseLogOutOptions = { type UseLogOutOptions = {
+logOutType?: 'legacy' | 'primary_device' | 'secondary_device', +logOutType?: 'legacy' | 'primary_device' | 'secondary_device',
+skipIdentityLogOut?: boolean,
}; };
function useLogOut( function useLogOut(
options: UseLogOutOptions = {}, options: UseLogOutOptions = {},
): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> { ): (keyserverIDs?: $ReadOnlyArray<string>) => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
const preRequestUserState = usePreRequestUserState(); const preRequestUserState = usePreRequestUserState();
const callKeyserverLogOut = useKeyserverCall(keyserverLogOut); const callKeyserverLogOut = useKeyserverCall(keyserverLogOut);
const commServicesAccessToken = useSelector( const commServicesAccessToken = useSelector(
state => state.commServicesAccessToken, state => state.commServicesAccessToken,
); );
const { logOutType } = options; const { logOutType, skipIdentityLogOut } = options;
return React.useCallback( return React.useCallback(
async (keyserverIDs?: $ReadOnlyArray<string>) => { async (keyserverIDs?: $ReadOnlyArray<string>) => {
const identityPromise = (async () => { const identityPromise = (async () => {
if (!usingCommServicesAccessToken || !commServicesAccessToken) { if (
skipIdentityLogOut ||
!usingCommServicesAccessToken ||
!commServicesAccessToken
) {
return; return;
} }
if (!identityClient) { if (!identityClient) {
throw new Error('Identity service client is not initialized'); throw new Error('Identity service client is not initialized');
} }
let callIdentityClientLogOut; let callIdentityClientLogOut;
if (logOutType === 'primary_device') { if (logOutType === 'primary_device') {
if (!identityClient.logOutPrimaryDevice) { if (!identityClient.logOutPrimaryDevice) {
Show All 36 Lines async (keyserverIDs?: $ReadOnlyArray<string>) => {
}; };
}, },
[ [
callKeyserverLogOut, callKeyserverLogOut,
commServicesAccessToken, commServicesAccessToken,
identityClient, identityClient,
logOutType, logOutType,
preRequestUserState, preRequestUserState,
skipIdentityLogOut,
], ],
); );
} }
function useIdentityLogOut(): () => Promise<LogOutResult> { function useIdentityLogOut(): () => Promise<LogOutResult> {
const client = React.useContext(IdentityClientContext); const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient; const identityClient = client?.identityClient;
▲ Show 20 Lines • Show All 1,230 Lines • Show Last 20 Lines