[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 7:36 PM.

Details

Reviewers

bartek
ashoat

Commits

rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs

Summary

.proto and grpc-web codegen changes. also added "unimplemented" gRPC handler methods to identity service

Depends on D11398

Test Plan

tested in subsequent diffs by calling the RPCs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 7:36 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 27 2024, 7:36 PM

varun added a child revision: D11400: [terraform] add GSI for farcasterID.Mar 27 2024, 7:39 PM

Harbormaster completed remote builds in B27714: Diff 38377.Mar 27 2024, 7:51 PM

varun requested review of this revision.Mar 27 2024, 7:51 PM

ashoat accepted this revision.Mar 28 2024, 12:21 AM

ashoat added inline comments.

shared/protos/identity_unauth.proto
293 ↗	(On Diff #38377)	Note to @bartek – @varun and I discussed this online and our thinking was that Ethereum users would have their wallet address here. This is similar to the approach I proposed in D11379

bartek accepted this revision.Mar 28 2024, 5:26 AM

This revision is now accepted and ready to land.Mar 28 2024, 5:26 AM

Closed by commit rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs. · Explain WhyMar 28 2024, 9:55 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

10 lines

grpc_services/

authenticated.rs

16 lines

shared/

protos/

identity_auth.proto

12 lines

identity_unauth.proto

20 lines

web/

protobufs/

identity-auth-client.cjs

identity-auth-client.cjs.flow

12 lines

identity-auth-structs.cjs

identity-auth-structs.cjs.flow

15 lines

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

60 lines

identity-unauth.cjs

identity-unauth.cjs.flow

12 lines

Diff 38497

View Options

services/identity/src/client_service.rs

View Options

services/identity/src/grpc_services/authenticated.rs

View Options

shared/protos/identity_auth.proto

View Options

shared/protos/identity_unauth.proto

View Options

web/protobufs/identity-auth-client.cjs

View Options

web/protobufs/identity-auth-client.cjs.flow

View Options

web/protobufs/identity-auth-structs.cjs

View Options

web/protobufs/identity-auth-structs.cjs.flow

View Options

web/protobufs/identity-unauth-structs.cjs

View Options

web/protobufs/identity-unauth-structs.cjs.flow

View Options

web/protobufs/identity-unauth.cjs

View Options

web/protobufs/identity-unauth.cjs.flow

[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38497

services/identity/src/client_service.rs

services/identity/src/grpc_services/authenticated.rs

shared/protos/identity_auth.proto

shared/protos/identity_unauth.proto

web/protobufs/identity-auth-client.cjs

web/protobufs/identity-auth-client.cjs.flow

web/protobufs/identity-auth-structs.cjs

web/protobufs/identity-auth-structs.cjs.flow

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

web/protobufs/identity-unauth.cjs

web/protobufs/identity-unauth.cjs.flow

[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
ClosedPublic
Actions

Revision Contents
Changeset List