Page MenuHomePhabricator
Differential D11410

[web] add client methods to web
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 18, 7:06 PM
Unknown Object (File)
Tue, Feb 18, 7:06 PM
Unknown Object (File)
Tue, Feb 18, 7:06 PM
Unknown Object (File)
Tue, Feb 18, 6:35 PM
Unknown Object (File)
Jan 19 2025, 5:08 AM
Unknown Object (File)
Jan 17 2025, 11:43 AM
Unknown Object (File)
Jan 17 2025, 8:26 AM
Unknown Object (File)
Jan 12 2025, 5:11 AM
View All 60 Files
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMM563337b5ede7: [web] add client methods to web
Summary

we will want to call these methods from web eventually, too.

Depends on D11409

Test Plan

called the client methods from root and confirmed that both work. The validator check succeeded in getFarcasterUsers, as well.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 1:08 PM
varun added a child revision: D11411: [identity] don't let linkFarcasterAccount overwrite existing fid for user.Mar 27 2024, 1:26 PM
Harbormaster completed remote builds in B27725: Diff 38388.Mar 27 2024, 1:36 PM
varun requested review of this revision.Mar 27 2024, 1:36 PM
ashoat accepted this revision.Mar 27 2024, 5:25 PM
This revision is now accepted and ready to land.Mar 27 2024, 5:25 PM
ashoat added a comment.Mar 27 2024, 5:33 PM

Do we need to update anything for registerPasswordUser or registerWalletUser on web?

varun added a comment.Mar 27 2024, 7:15 PM
In D11410#329193, @ashoat wrote:

Do we need to update anything for registerPasswordUser or registerWalletUser on web?

I updated the generated grpc-web files in D11396 , but we don't allow registration on web so there's nothing to update here

ashoat added a comment.Mar 28 2024, 6:29 AM

Right, my bad!

Closed by commit rCOMM563337b5ede7: [web] add client methods to web (authored by varun). · Explain WhyMar 28 2024, 3:17 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM563337b5ede7: [web] add client methods to web.

Revision Contents
Changeset List

Diff 38508

View Options

lib/types/identity-service-types.js

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines try {
}, },
}); });
const json: FetchFarcasterChannelByNameResponse = await response.json(); const json: FetchFarcasterChannelByNameResponse = await response.json();
const { channels } = json; const { channels } = json;
for (const channel of channels) { for (const channel of channels) {
if (channel.name.toLowerCase() === channelName.toLowerCase()) { if (channel.id.toLowerCase() === channelName.toLowerCase()) {
return channel; return channel;
} }
} }
return null; return null;
} catch (error) { } catch (error) {
console.log( console.log(
'Failed to search Farcaster channel by name:', 'Failed to search Farcaster channel by name:',
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines
View Options

web/grpc/identity-service-client-wrapper.js

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines try {
}, },
}); });
const json: FetchFarcasterChannelByNameResponse = await response.json(); const json: FetchFarcasterChannelByNameResponse = await response.json();
const { channels } = json; const { channels } = json;
for (const channel of channels) { for (const channel of channels) {
if (channel.name.toLowerCase() === channelName.toLowerCase()) { if (channel.id.toLowerCase() === channelName.toLowerCase()) {
return channel; return channel;
} }
} }
return null; return null;
} catch (error) { } catch (error) {
console.log( console.log(
'Failed to search Farcaster channel by name:', 'Failed to search Farcaster channel by name:',
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines
View Options

web/grpc/identity-service-context-provider.react.js

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines try {
}, },
}); });
const json: FetchFarcasterChannelByNameResponse = await response.json(); const json: FetchFarcasterChannelByNameResponse = await response.json();
const { channels } = json; const { channels } = json;
for (const channel of channels) { for (const channel of channels) {
if (channel.name.toLowerCase() === channelName.toLowerCase()) { if (channel.id.toLowerCase() === channelName.toLowerCase()) {
return channel; return channel;
} }
} }
return null; return null;
} catch (error) { } catch (error) {
console.log( console.log(
'Failed to search Farcaster channel by name:', 'Failed to search Farcaster channel by name:',
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines