Paths

Table of Contentst

Differential D11411

[identity] don't let linkFarcasterAccount overwrite existing fid for user
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 1:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 26, 11:13 AM

	Unknown Object (File)
	Fri, Apr 12, 1:29 AM

	Unknown Object (File)
	Fri, Apr 12, 1:29 AM

	Unknown Object (File)
	Fri, Apr 12, 1:29 AM

	Unknown Object (File)
	Fri, Apr 12, 1:29 AM

	Unknown Object (File)
	Tue, Apr 9, 2:56 AM

	Unknown Object (File)
	Tue, Apr 2, 3:58 PM

	Unknown Object (File)
	Tue, Apr 2, 2:16 PM

View All 9 Files

Subscribers

Details

Reviewers

Commits

rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user

Summary

https://linear.app/comm/issue/ENG-7358/make-sure-only-1-fid-is-associated-with-a-given-comm-user

Depends on D11410

Test Plan

tried calling linkFarcasterAccount multiple times. attempts with the same FID succeeded but attempts with a different FID failed.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 1:26 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 1:26 PM

varun added a child revision: D11412: [identity] check if fid is already taken when registering new user.Mar 27 2024, 1:28 PM

Harbormaster completed remote builds in B27726: Diff 38389.Mar 27 2024, 1:40 PM

varun requested review of this revision.Mar 27 2024, 1:40 PM

ashoat added a comment.Mar 27 2024, 5:28 PM

This comment was removed by ashoat.

bartek accepted this revision.Mar 27 2024, 11:20 PM

bartek added inline comments.

services/identity/src/database/farcaster.rs
68–72 ↗	(On Diff #38389)	You don't have to provide the same value twice
88 ↗	(On Diff #38389)	Does `UpdateExpression` `if_not_exists` fail the operation if given value already exists? The docs don't say this explicitly, but I guess `if_not_exists (path, value)` If the item does not contain an attribute at the specified `path`, `if_not_exists` evaluates to `value`; otherwise, it evaluates to `path`. means that if the ID already exists, the expression evaluates to `SET farcasterID = farcasterID` so it's a no-op. According to your test plan, it succeeds so it's alright

This revision is now accepted and ready to land.Mar 27 2024, 11:20 PM

varun added inline comments.Mar 28 2024, 2:33 PM

services/identity/src/database/farcaster.rs
88 ↗	(On Diff #38389)	yeah i checked and it succeeds so assuming DDB treats it as a no-op

Closed by commit rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user (authored by varun). · Explain WhyMar 28 2024, 3:17 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

26 lines

2 lines

Diff 38509

services/identity/src/database/farcaster.rs

Loading...

services/identity/src/error.rs

Loading...