Page MenuHomePhabricator
Differential D11411

[identity] don't let linkFarcasterAccount overwrite existing fid for user
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 5:58 AM
Unknown Object (File)
Sun, Mar 30, 2:04 PM
Unknown Object (File)
Sun, Mar 30, 12:54 PM
Unknown Object (File)
Sat, Mar 29, 12:33 PM
Unknown Object (File)
Feb 21 2025, 5:57 AM
Unknown Object (File)
Feb 18 2025, 7:06 PM
Unknown Object (File)
Feb 18 2025, 7:06 PM
Unknown Object (File)
Feb 18 2025, 7:06 PM
View All 65 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user
Summary

https://linear.app/comm/issue/ENG-7358/make-sure-only-1-fid-is-associated-with-a-given-comm-user

Depends on D11410

Test Plan

tried calling linkFarcasterAccount multiple times. attempts with the same FID succeeded but attempts with a different FID failed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 1:26 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 1:26 PM
varun added a child revision: D11412: [identity] check if fid is already taken when registering new user.Mar 27 2024, 1:28 PM
Harbormaster completed remote builds in B27726: Diff 38389.Mar 27 2024, 1:40 PM
varun requested review of this revision.Mar 27 2024, 1:40 PM
ashoat added a comment.Mar 27 2024, 5:28 PM
This comment was removed by ashoat.
bartek accepted this revision.Mar 27 2024, 11:20 PM
bartek added inline comments.
services/identity/src/database/farcaster.rs
68–72 ↗(On Diff #38389)

You don't have to provide the same value twice

88 ↗(On Diff #38389)

Does UpdateExpression if_not_exists fail the operation if given value already exists? The docs don't say this explicitly, but I guess

  • if_not_exists (path, value)

If the item does not contain an attribute at the specified path, if_not_exists evaluates to value; otherwise, it evaluates to path.

means that if the ID already exists, the expression evaluates to SET farcasterID = farcasterID so it's a no-op.

According to your test plan, it succeeds so it's alright

This revision is now accepted and ready to land.Mar 27 2024, 11:20 PM
varun added inline comments.Mar 28 2024, 2:33 PM
services/identity/src/database/farcaster.rs
88 ↗(On Diff #38389)

yeah i checked and it succeeds so assuming DDB treats it as a no-op

Closed by commit rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user (authored by varun). · Explain WhyMar 28 2024, 3:17 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM8ec3ffdc4d77: [identity] don't let linkFarcasterAccount overwrite existing fid for user.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
database/
26 lines
2 lines

Diff 38509

View Options

services/identity/src/database/farcaster.rs

Show All 21 Linesimport {
assignHolder, assignHolder,
download, download,
deleteBlob, deleteBlob,
type BlobOperationResult, type BlobOperationResult,
type BlobDownloadResult, type BlobDownloadResult,
} from '../services/blob.js'; } from '../services/blob.js';
import { Viewer } from '../session/viewer.js'; import { Viewer } from '../session/viewer.js';
import { thisKeyserverID } from '../user/identity.js'; import { thisKeyserverID } from '../user/identity.js';
import { getAndAssertKeyserverURLFacts } from '../utils/urls.js';
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
const permissionPromise = checkThreadPermission( const permissionPromise = checkThreadPermission(
viewer, viewer,
request.commCommunityID, request.commCommunityID,
▲ Show 20 Lines • Show All 105 Lines • ▼ Show 20 Lines): Promise<BlobDownloadResult> {
return download(hash); return download(hash);
} }
async function uploadFarcasterChannelTagBlob( async function uploadFarcasterChannelTagBlob(
commCommunityID: string, commCommunityID: string,
farcasterChannelID: string, farcasterChannelID: string,
holder: string, holder: string,
): Promise<BlobOperationResult> { ): Promise<BlobOperationResult> {
const { baseDomain, basePath } = getAndAssertKeyserverURLFacts();
const keyserverURL = baseDomain + basePath;
const payload = { const payload = {
commCommunityID, commCommunityID,
farcasterChannelID, farcasterChannelID,
keyserverURL,
}; };
const payloadString = JSON.stringify(payload); const payloadString = JSON.stringify(payload);
const hash = farcasterChannelTagBlobHash(farcasterChannelID); const hash = farcasterChannelTagBlobHash(farcasterChannelID);
const blob = new Blob([payloadString]); const blob = new Blob([payloadString]);
const uploadResult = await uploadBlob(blob, hash); const uploadResult = await uploadBlob(blob, hash);
if (!uploadResult.success) { if (!uploadResult.success) {
return uploadResult; return uploadResult;
} }
return await assignHolder({ holder, hash }); return await assignHolder({ holder, hash });
} }
export { createOrUpdateFarcasterChannelTag, uploadFarcasterChannelTagBlob }; export { createOrUpdateFarcasterChannelTag, uploadFarcasterChannelTagBlob };
View Options

services/identity/src/error.rs

Show All 21 Linesimport {
assignHolder, assignHolder,
download, download,
deleteBlob, deleteBlob,
type BlobOperationResult, type BlobOperationResult,
type BlobDownloadResult, type BlobDownloadResult,
} from '../services/blob.js'; } from '../services/blob.js';
import { Viewer } from '../session/viewer.js'; import { Viewer } from '../session/viewer.js';
import { thisKeyserverID } from '../user/identity.js'; import { thisKeyserverID } from '../user/identity.js';
import { getAndAssertKeyserverURLFacts } from '../utils/urls.js';
async function createOrUpdateFarcasterChannelTag( async function createOrUpdateFarcasterChannelTag(
viewer: Viewer, viewer: Viewer,
request: CreateOrUpdateFarcasterChannelTagRequest, request: CreateOrUpdateFarcasterChannelTagRequest,
): Promise<CreateOrUpdateFarcasterChannelTagResponse> { ): Promise<CreateOrUpdateFarcasterChannelTagResponse> {
const permissionPromise = checkThreadPermission( const permissionPromise = checkThreadPermission(
viewer, viewer,
request.commCommunityID, request.commCommunityID,
▲ Show 20 Lines • Show All 105 Lines • ▼ Show 20 Lines): Promise<BlobDownloadResult> {
return download(hash); return download(hash);
} }
async function uploadFarcasterChannelTagBlob( async function uploadFarcasterChannelTagBlob(
commCommunityID: string, commCommunityID: string,
farcasterChannelID: string, farcasterChannelID: string,
holder: string, holder: string,
): Promise<BlobOperationResult> { ): Promise<BlobOperationResult> {
const { baseDomain, basePath } = getAndAssertKeyserverURLFacts();
const keyserverURL = baseDomain + basePath;
const payload = { const payload = {
commCommunityID, commCommunityID,
farcasterChannelID, farcasterChannelID,
keyserverURL,
}; };
const payloadString = JSON.stringify(payload); const payloadString = JSON.stringify(payload);
const hash = farcasterChannelTagBlobHash(farcasterChannelID); const hash = farcasterChannelTagBlobHash(farcasterChannelID);
const blob = new Blob([payloadString]); const blob = new Blob([payloadString]);
const uploadResult = await uploadBlob(blob, hash); const uploadResult = await uploadBlob(blob, hash);
if (!uploadResult.success) { if (!uploadResult.success) {
return uploadResult; return uploadResult;
} }
return await assignHolder({ holder, hash }); return await assignHolder({ holder, hash });
} }
export { createOrUpdateFarcasterChannelTag, uploadFarcasterChannelTagBlob }; export { createOrUpdateFarcasterChannelTag, uploadFarcasterChannelTagBlob };