Page MenuHomePhabricator
Differential D11403

[native_rust_library] get_farcaster_users client method
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 9:10 PM
Unknown Object (File)
Sat, Apr 12, 7:38 PM
Unknown Object (File)
Sun, Mar 30, 9:42 AM
Unknown Object (File)
Sun, Mar 30, 4:46 AM
Unknown Object (File)
Sun, Mar 30, 12:34 AM
Unknown Object (File)
Sat, Mar 29, 2:18 AM
Unknown Object (File)
Feb 27 2025, 4:33 AM
Unknown Object (File)
Feb 18 2025, 7:38 PM
View All 62 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method
Summary

native rust client method to call the GetFarcasterUsers RPC. this will be called to get the Comm user info for a user's Farcaster follows

Depends on D11402

Test Plan

later in the stack I add a method to the native IdentityServiceContextProvider which calls this method. This method successfully returns a list of FarcasterUsers.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 12:48 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 12:48 PM
varun added a child revision: D11404: [native] add getFarcasterUsers to commRustModule.Mar 27 2024, 12:50 PM
Harbormaster completed remote builds in B27718: Diff 38381.Mar 27 2024, 1:05 PM
varun requested review of this revision.Mar 27 2024, 1:05 PM
bartek accepted this revision.Mar 27 2024, 11:01 PM
bartek added inline comments.
native/native_rust_library/src/farcaster.rs
55–59 ↗(On Diff #38381)

Possibly we can impl From<gprc_clients::identity::protos::unauth::FarcasterUser> for FarcasterUser but not worth for a single usecase

This revision is now accepted and ready to land.Mar 27 2024, 11:01 PM
varun added inline comments.Mar 28 2024, 2:16 PM
native/native_rust_library/src/farcaster.rs
55–59 ↗(On Diff #38381)

Yeah I think not worth it rn. Maybe if we find other use cases later

Closed by commit rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method (authored by varun). · Explain WhyMar 28 2024, 3:13 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
56 lines
6 lines

Diff 38502

View Options

native/native_rust_library/src/farcaster.rs

// @flow // @flow
import { oldValidUsernameRegexString } from './account-utils.js'; import { oldValidUsernameRegexString } from './account-utils.js';
import SentencePrefixSearchIndex from './sentence-prefix-search-index.js'; import SentencePrefixSearchIndex from './sentence-prefix-search-index.js';
import { threadOtherMembers } from './thread-utils.js'; import { threadOtherMembers } from './thread-utils.js';
import { stringForUserExplicit } from './user-utils.js'; import { stringForUserExplicit } from './user-utils.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo, MinimallyEncodedRelativeMemberInfo,
MinimallyEncodedResolvedThreadInfo, MinimallyEncodedResolvedThreadInfo,
MinimallyEncodedThreadInfo, MinimallyEncodedThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadTypes } from '../types/thread-types-enum.js'; import { threadTypes } from '../types/thread-types-enum.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
ResolvedThreadInfo, ResolvedThreadInfo,
ChatMentionCandidates, ChatMentionCandidates,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { idSchemaRegex, chatNameMaxLength } from '../utils/validation-utils.js'; import { idSchemaRegex, chatNameMaxLength } from '../utils/validation-utils.js';
export type TypeaheadMatchedStrings = { export type TypeaheadMatchedStrings = {
+textBeforeAtSymbol: string, +textBeforeAtSymbol: string,
+query: string, +query: string,
}; };
export type Selection = { export type Selection = {
+start: number, +start: number,
+end: number, +end: number,
}; };
type MentionTypeaheadUserSuggestionItem = { type MentionTypeaheadUserSuggestionItem = {
+type: 'user', +type: 'user',
+userInfo: RelativeMemberInfo | MinimallyEncodedRelativeMemberInfo, +userInfo: LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
}; };
type MentionTypeaheadChatSuggestionItem = { type MentionTypeaheadChatSuggestionItem = {
+type: 'chat', +type: 'chat',
+threadInfo: ResolvedThreadInfo | MinimallyEncodedResolvedThreadInfo, +threadInfo: ResolvedThreadInfo | MinimallyEncodedResolvedThreadInfo,
}; };
export type MentionTypeaheadSuggestionItem = export type MentionTypeaheadSuggestionItem =
▲ Show 20 Lines • Show All 63 Lines • ▼ Show 20 Lines ) {
return text.slice(0, selection.start).match(regex); return text.slice(0, selection.start).match(regex);
} }
return null; return null;
} }
function getMentionTypeaheadUserSuggestions( function getMentionTypeaheadUserSuggestions(
userSearchIndex: SentencePrefixSearchIndex, userSearchIndex: SentencePrefixSearchIndex,
threadMembers: $ReadOnlyArray< threadMembers: $ReadOnlyArray<
RelativeMemberInfo | MinimallyEncodedRelativeMemberInfo, LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>, >,
viewerID: ?string, viewerID: ?string,
usernamePrefix: string, usernamePrefix: string,
): $ReadOnlyArray<MentionTypeaheadUserSuggestionItem> { ): $ReadOnlyArray<MentionTypeaheadUserSuggestionItem> {
const userIDs = userSearchIndex.getSearchResults(usernamePrefix); const userIDs = userSearchIndex.getSearchResults(usernamePrefix);
const usersInThread = threadOtherMembers(threadMembers, viewerID); const usersInThread = threadOtherMembers(threadMembers, viewerID);
return usersInThread return usersInThread
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines): {
const newSelectionStart = newText.length - newSuffixText.length + 1; const newSelectionStart = newText.length - newSuffixText.length + 1;
return { newText, newSelectionStart }; return { newText, newSelectionStart };
} }
function getUserMentionsCandidates( function getUserMentionsCandidates(
threadInfo: ThreadInfo | MinimallyEncodedThreadInfo, threadInfo: ThreadInfo | MinimallyEncodedThreadInfo,
parentThreadInfo: ?ThreadInfo | ?MinimallyEncodedThreadInfo, parentThreadInfo: ?ThreadInfo | ?MinimallyEncodedThreadInfo,
): $ReadOnlyArray<RelativeMemberInfo | MinimallyEncodedRelativeMemberInfo> { ): $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
> {
if (threadInfo.type !== threadTypes.SIDEBAR) { if (threadInfo.type !== threadTypes.SIDEBAR) {
return threadInfo.members; return threadInfo.members;
} }
if (parentThreadInfo) { if (parentThreadInfo) {
return parentThreadInfo.members; return parentThreadInfo.members;
} }
// This scenario should not occur unless the user logs out while looking at a // This scenario should not occur unless the user logs out while looking at a
// sidebar. In that scenario, the Redux store may be cleared before ReactNav // sidebar. In that scenario, the Redux store may be cleared before ReactNav
Show All 19 Lines
View Options

native/native_rust_library/src/lib.rs

// @flow // @flow
import { oldValidUsernameRegexString } from './account-utils.js'; import { oldValidUsernameRegexString } from './account-utils.js';
import SentencePrefixSearchIndex from './sentence-prefix-search-index.js'; import SentencePrefixSearchIndex from './sentence-prefix-search-index.js';
import { threadOtherMembers } from './thread-utils.js'; import { threadOtherMembers } from './thread-utils.js';
import { stringForUserExplicit } from './user-utils.js'; import { stringForUserExplicit } from './user-utils.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo, MinimallyEncodedRelativeMemberInfo,
MinimallyEncodedResolvedThreadInfo, MinimallyEncodedResolvedThreadInfo,
MinimallyEncodedThreadInfo, MinimallyEncodedThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import { threadTypes } from '../types/thread-types-enum.js'; import { threadTypes } from '../types/thread-types-enum.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
ResolvedThreadInfo, ResolvedThreadInfo,
ChatMentionCandidates, ChatMentionCandidates,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { idSchemaRegex, chatNameMaxLength } from '../utils/validation-utils.js'; import { idSchemaRegex, chatNameMaxLength } from '../utils/validation-utils.js';
export type TypeaheadMatchedStrings = { export type TypeaheadMatchedStrings = {
+textBeforeAtSymbol: string, +textBeforeAtSymbol: string,
+query: string, +query: string,
}; };
export type Selection = { export type Selection = {
+start: number, +start: number,
+end: number, +end: number,
}; };
type MentionTypeaheadUserSuggestionItem = { type MentionTypeaheadUserSuggestionItem = {
+type: 'user', +type: 'user',
+userInfo: RelativeMemberInfo | MinimallyEncodedRelativeMemberInfo, +userInfo: LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
}; };
type MentionTypeaheadChatSuggestionItem = { type MentionTypeaheadChatSuggestionItem = {
+type: 'chat', +type: 'chat',
+threadInfo: ResolvedThreadInfo | MinimallyEncodedResolvedThreadInfo, +threadInfo: ResolvedThreadInfo | MinimallyEncodedResolvedThreadInfo,
}; };
export type MentionTypeaheadSuggestionItem = export type MentionTypeaheadSuggestionItem =
▲ Show 20 Lines • Show All 63 Lines • ▼ Show 20 Lines ) {
return text.slice(0, selection.start).match(regex); return text.slice(0, selection.start).match(regex);
} }
return null; return null;
} }
function getMentionTypeaheadUserSuggestions( function getMentionTypeaheadUserSuggestions(
userSearchIndex: SentencePrefixSearchIndex, userSearchIndex: SentencePrefixSearchIndex,
threadMembers: $ReadOnlyArray< threadMembers: $ReadOnlyArray<
RelativeMemberInfo | MinimallyEncodedRelativeMemberInfo, LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>, >,
viewerID: ?string, viewerID: ?string,
usernamePrefix: string, usernamePrefix: string,
): $ReadOnlyArray<MentionTypeaheadUserSuggestionItem> { ): $ReadOnlyArray<MentionTypeaheadUserSuggestionItem> {
const userIDs = userSearchIndex.getSearchResults(usernamePrefix); const userIDs = userSearchIndex.getSearchResults(usernamePrefix);
const usersInThread = threadOtherMembers(threadMembers, viewerID); const usersInThread = threadOtherMembers(threadMembers, viewerID);
return usersInThread return usersInThread
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines): {
const newSelectionStart = newText.length - newSuffixText.length + 1; const newSelectionStart = newText.length - newSuffixText.length + 1;
return { newText, newSelectionStart }; return { newText, newSelectionStart };
} }
function getUserMentionsCandidates( function getUserMentionsCandidates(
threadInfo: ThreadInfo | MinimallyEncodedThreadInfo, threadInfo: ThreadInfo | MinimallyEncodedThreadInfo,
parentThreadInfo: ?ThreadInfo | ?MinimallyEncodedThreadInfo, parentThreadInfo: ?ThreadInfo | ?MinimallyEncodedThreadInfo,
): $ReadOnlyArray<RelativeMemberInfo | MinimallyEncodedRelativeMemberInfo> { ): $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
> {
if (threadInfo.type !== threadTypes.SIDEBAR) { if (threadInfo.type !== threadTypes.SIDEBAR) {
return threadInfo.members; return threadInfo.members;
} }
if (parentThreadInfo) { if (parentThreadInfo) {
return parentThreadInfo.members; return parentThreadInfo.members;
} }
// This scenario should not occur unless the user logs out while looking at a // This scenario should not occur unless the user logs out while looking at a
// sidebar. In that scenario, the Redux store may be cleared before ReactNav // sidebar. In that scenario, the Redux store may be cleared before ReactNav
Show All 19 Lines