Page MenuHomePhabricator
Differential D11403

[native_rust_library] get_farcaster_users client method
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 9:42 AM
Unknown Object (File)
Sun, Mar 30, 4:46 AM
Unknown Object (File)
Sun, Mar 30, 12:34 AM
Unknown Object (File)
Sat, Mar 29, 2:18 AM
Unknown Object (File)
Feb 27 2025, 4:33 AM
Unknown Object (File)
Feb 18 2025, 7:38 PM
Unknown Object (File)
Feb 18 2025, 7:38 PM
Unknown Object (File)
Feb 18 2025, 7:38 PM
View All 60 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method
Summary

native rust client method to call the GetFarcasterUsers RPC. this will be called to get the Comm user info for a user's Farcaster follows

Depends on D11402

Test Plan

later in the stack I add a method to the native IdentityServiceContextProvider which calls this method. This method successfully returns a list of FarcasterUsers.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 12:48 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 12:48 PM
varun added a child revision: D11404: [native] add getFarcasterUsers to commRustModule.Mar 27 2024, 12:50 PM
Harbormaster completed remote builds in B27718: Diff 38381.Mar 27 2024, 1:05 PM
varun requested review of this revision.Mar 27 2024, 1:05 PM
bartek accepted this revision.Mar 27 2024, 11:01 PM
bartek added inline comments.
native/native_rust_library/src/farcaster.rs
55–59 ↗(On Diff #38381)

Possibly we can impl From<gprc_clients::identity::protos::unauth::FarcasterUser> for FarcasterUser but not worth for a single usecase

This revision is now accepted and ready to land.Mar 27 2024, 11:01 PM
varun added inline comments.Mar 28 2024, 2:16 PM
native/native_rust_library/src/farcaster.rs
55–59 ↗(On Diff #38381)

Yeah I think not worth it rn. Maybe if we find other use cases later

Closed by commit rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method (authored by varun). · Explain WhyMar 28 2024, 3:13 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMa9273fca68b7: [native_rust_library] get_farcaster_users client method.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
56 lines
6 lines

Diff 38502

View Options

native/native_rust_library/src/farcaster.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };
View Options

native/native_rust_library/src/lib.rs

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines +getInboundKeysForUserDevice: (
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userId: string, userId: string,
deviceId: string, deviceId: string,
) => Promise<InboundKeyInfoResponse>, ) => Promise<InboundKeyInfoResponse>,
+getFarcasterUsers: ( +getFarcasterUsers: (
farcasterIds: $ReadOnlyArray<string>, farcasterIds: $ReadOnlyArray<string>,
) => Promise<$ReadOnlyArray<FarcasterUser>>, ) => Promise<$ReadOnlyArray<FarcasterUser>>,
+generateNonce: () => Promise<string>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };