[proto][identity] add optional fid to registration request messages
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 12:26 PM.

Details

Reviewers

bartek
ashoat

Commits

rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages

Summary

update proto
add farcaster id to dynamodb users table on registration
update rust clients to send None for now (will send actual FID in next diff)
update grpc-web bindings with farcaster id in registration requests

Test Plan

tested in subsequent diff by actually calling the updated register RPC from native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 12:26 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 27 2024, 12:26 PM

varun added a child revision: D11397: [native_rust_library] use farcaster id on register_wallet_user and register_password_user.Mar 27 2024, 12:28 PM

Harbormaster completed remote builds in B27711: Diff 38374.Mar 27 2024, 12:42 PM

varun requested review of this revision.Mar 27 2024, 12:42 PM

varun added a child revision: D11398: [native] expose farcaster id param to native identity service context provider.Mar 27 2024, 1:44 PM

ashoat accepted this revision.Mar 27 2024, 5:19 PM

varun mentioned this in D11410: [web] add client methods to web.Mar 27 2024, 7:15 PM

bartek accepted this revision.Mar 27 2024, 10:23 PM

This revision is now accepted and ready to land.Mar 27 2024, 10:23 PM

Closed by commit rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages (authored by varun). · Explain WhyMar 28 2024, 2:55 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

register_user.rs

1 line

native/

native_rust_library/

src/

lib.rs

2 lines

wallet_registration.rs

1 line

services/

commtest/

src/

identity/

device.rs

1 line

identity/

src/

client_service.rs

7 lines

constants.rs

1 line

database.rs

18 lines

shared/

protos/

identity_unauth.proto

2 lines

web/

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

12 lines

Diff 38495

View Options

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/native_rust_library/src/wallet_registration.rs

View Options

services/commtest/src/identity/device.rs

View Options

services/identity/src/client_service.rs

View Options

services/identity/src/constants.rs

View Options

services/identity/src/database.rs

View Options

shared/protos/identity_unauth.proto

View Options

web/protobufs/identity-unauth-structs.cjs

View Options

web/protobufs/identity-unauth-structs.cjs.flow

[proto][identity] add optional fid to registration request messagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38495

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

native/native_rust_library/src/lib.rs

native/native_rust_library/src/wallet_registration.rs

services/commtest/src/identity/device.rs

services/identity/src/client_service.rs

services/identity/src/constants.rs

services/identity/src/database.rs

shared/protos/identity_unauth.proto

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

[proto][identity] add optional fid to registration request messages
ClosedPublic
Actions

Revision Contents
Changeset List