Page MenuHomePhabricator
Differential D11396

[proto][identity] add optional fid to registration request messages
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 12:26 PM.
Tags
None
Referenced Files
F5100467: D11396.id38374.diff
Mon, Mar 31, 1:05 PM
Unknown Object (File)
Sun, Mar 30, 11:34 AM
Unknown Object (File)
Sun, Mar 30, 12:00 AM
Unknown Object (File)
Sat, Mar 29, 3:18 PM
Unknown Object (File)
Fri, Mar 21, 5:51 PM
Unknown Object (File)
Feb 27 2025, 1:59 AM
Unknown Object (File)
Feb 18 2025, 7:55 PM
Unknown Object (File)
Feb 18 2025, 7:55 PM
View All 70 Files
Subscribers
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMM75706c132d20: [proto][identity] add optional fid to registration request messages
Summary
  • update proto
  • add farcaster id to dynamodb users table on registration
  • update rust clients to send None for now (will send actual FID in next diff)
  • update grpc-web bindings with farcaster id in registration requests
Test Plan

tested in subsequent diff by actually calling the updated register RPC from native

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
src/
identity_client/
1 line
native/
native_rust_library/
src/
2 lines
1 line
services/
commtest/
src/
identity/
1 line
identity/
src/
7 lines
1 line
18 lines
shared/
protos/
2 lines
web/
protobufs/
12 lines

Diff 38374

View Options

keyserver/addons/rust-node-addon/src/identity_client/register_user.rs

  • This file was added.
use lazy_static::lazy_static;
use regex::Regex;
use std::path::PathBuf;
lazy_static! {
static ref BACKUP_DATA_FILE_REGEX: Regex = Regex::new(
r"^backup-(?<backup_id>[^-]*)(?:-log-(?<log_id>\d*))?(?<additional_data>-userkeys|-attachments)?$"
)
.expect("Regex compilation failed");
}
#[derive(Debug)]
pub struct BackupFileInfo {
pub backup_id: String,
pub log_id: Option<usize>,
pub additional_data: Option<String>,
}
impl TryFrom<PathBuf> for BackupFileInfo {
type Error = ();
fn try_from(value: PathBuf) -> Result<Self, Self::Error> {
let Some(file_name) = value.file_name() else {
return Err(());
};
let file_name = file_name.to_string_lossy();
let Some(captures) = BACKUP_DATA_FILE_REGEX.captures(&file_name) else {
return Err(());
};
let Some(backup_id) = captures
.name("backup_id")
.map(|re_match| re_match.as_str().to_string())
else {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'backup_id' from backup filename: {file_name:?}"
);
return Err(());
};
let log_id = match captures
.name("log_id")
.map(|re_match| re_match.as_str().parse::<usize>())
{
None => None,
Some(Ok(log_id)) => Some(log_id),
Some(Err(err)) => {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'log_id' from backup filename: {file_name:?}. \
Error: {err:?}"
);
return Err(());
}
};
let additional_data = captures
.name("additional_data")
.map(|m| m.as_str().to_string());
Ok(Self {
backup_id,
log_id,
additional_data,
})
}
}
View Options

native/native_rust_library/src/lib.rs

  • This file was added.
use lazy_static::lazy_static;
use regex::Regex;
use std::path::PathBuf;
lazy_static! {
static ref BACKUP_DATA_FILE_REGEX: Regex = Regex::new(
r"^backup-(?<backup_id>[^-]*)(?:-log-(?<log_id>\d*))?(?<additional_data>-userkeys|-attachments)?$"
)
.expect("Regex compilation failed");
}
#[derive(Debug)]
pub struct BackupFileInfo {
pub backup_id: String,
pub log_id: Option<usize>,
pub additional_data: Option<String>,
}
impl TryFrom<PathBuf> for BackupFileInfo {
type Error = ();
fn try_from(value: PathBuf) -> Result<Self, Self::Error> {
let Some(file_name) = value.file_name() else {
return Err(());
};
let file_name = file_name.to_string_lossy();
let Some(captures) = BACKUP_DATA_FILE_REGEX.captures(&file_name) else {
return Err(());
};
let Some(backup_id) = captures
.name("backup_id")
.map(|re_match| re_match.as_str().to_string())
else {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'backup_id' from backup filename: {file_name:?}"
);
return Err(());
};
let log_id = match captures
.name("log_id")
.map(|re_match| re_match.as_str().parse::<usize>())
{
None => None,
Some(Ok(log_id)) => Some(log_id),
Some(Err(err)) => {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'log_id' from backup filename: {file_name:?}. \
Error: {err:?}"
);
return Err(());
}
};
let additional_data = captures
.name("additional_data")
.map(|m| m.as_str().to_string());
Ok(Self {
backup_id,
log_id,
additional_data,
})
}
}
View Options

native/native_rust_library/src/wallet_registration.rs

  • This file was added.
use lazy_static::lazy_static;
use regex::Regex;
use std::path::PathBuf;
lazy_static! {
static ref BACKUP_DATA_FILE_REGEX: Regex = Regex::new(
r"^backup-(?<backup_id>[^-]*)(?:-log-(?<log_id>\d*))?(?<additional_data>-userkeys|-attachments)?$"
)
.expect("Regex compilation failed");
}
#[derive(Debug)]
pub struct BackupFileInfo {
pub backup_id: String,
pub log_id: Option<usize>,
pub additional_data: Option<String>,
}
impl TryFrom<PathBuf> for BackupFileInfo {
type Error = ();
fn try_from(value: PathBuf) -> Result<Self, Self::Error> {
let Some(file_name) = value.file_name() else {
return Err(());
};
let file_name = file_name.to_string_lossy();
let Some(captures) = BACKUP_DATA_FILE_REGEX.captures(&file_name) else {
return Err(());
};
let Some(backup_id) = captures
.name("backup_id")
.map(|re_match| re_match.as_str().to_string())
else {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'backup_id' from backup filename: {file_name:?}"
);
return Err(());
};
let log_id = match captures
.name("log_id")
.map(|re_match| re_match.as_str().parse::<usize>())
{
None => None,
Some(Ok(log_id)) => Some(log_id),
Some(Err(err)) => {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'log_id' from backup filename: {file_name:?}. \
Error: {err:?}"
);
return Err(());
}
};
let additional_data = captures
.name("additional_data")
.map(|m| m.as_str().to_string());
Ok(Self {
backup_id,
log_id,
additional_data,
})
}
}
View Options

services/commtest/src/identity/device.rs

  • This file was added.
use lazy_static::lazy_static;
use regex::Regex;
use std::path::PathBuf;
lazy_static! {
static ref BACKUP_DATA_FILE_REGEX: Regex = Regex::new(
r"^backup-(?<backup_id>[^-]*)(?:-log-(?<log_id>\d*))?(?<additional_data>-userkeys|-attachments)?$"
)
.expect("Regex compilation failed");
}
#[derive(Debug)]
pub struct BackupFileInfo {
pub backup_id: String,
pub log_id: Option<usize>,
pub additional_data: Option<String>,
}
impl TryFrom<PathBuf> for BackupFileInfo {
type Error = ();
fn try_from(value: PathBuf) -> Result<Self, Self::Error> {
let Some(file_name) = value.file_name() else {
return Err(());
};
let file_name = file_name.to_string_lossy();
let Some(captures) = BACKUP_DATA_FILE_REGEX.captures(&file_name) else {
return Err(());
};
let Some(backup_id) = captures
.name("backup_id")
.map(|re_match| re_match.as_str().to_string())
else {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'backup_id' from backup filename: {file_name:?}"
);
return Err(());
};
let log_id = match captures
.name("log_id")
.map(|re_match| re_match.as_str().parse::<usize>())
{
None => None,
Some(Ok(log_id)) => Some(log_id),
Some(Err(err)) => {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'log_id' from backup filename: {file_name:?}. \
Error: {err:?}"
);
return Err(());
}
};
let additional_data = captures
.name("additional_data")
.map(|m| m.as_str().to_string());
Ok(Self {
backup_id,
log_id,
additional_data,
})
}
}
View Options

services/identity/src/client_service.rs

  • This file was added.
use lazy_static::lazy_static;
use regex::Regex;
use std::path::PathBuf;
lazy_static! {
static ref BACKUP_DATA_FILE_REGEX: Regex = Regex::new(
r"^backup-(?<backup_id>[^-]*)(?:-log-(?<log_id>\d*))?(?<additional_data>-userkeys|-attachments)?$"
)
.expect("Regex compilation failed");
}
#[derive(Debug)]
pub struct BackupFileInfo {
pub backup_id: String,
pub log_id: Option<usize>,
pub additional_data: Option<String>,
}
impl TryFrom<PathBuf> for BackupFileInfo {
type Error = ();
fn try_from(value: PathBuf) -> Result<Self, Self::Error> {
let Some(file_name) = value.file_name() else {
return Err(());
};
let file_name = file_name.to_string_lossy();
let Some(captures) = BACKUP_DATA_FILE_REGEX.captures(&file_name) else {
return Err(());
};
let Some(backup_id) = captures
.name("backup_id")
.map(|re_match| re_match.as_str().to_string())
else {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'backup_id' from backup filename: {file_name:?}"
);
return Err(());
};
let log_id = match captures
.name("log_id")
.map(|re_match| re_match.as_str().parse::<usize>())
{
None => None,
Some(Ok(log_id)) => Some(log_id),
Some(Err(err)) => {
// Should never happen happen because regex matched the filename
println!(
"Couldn't parse 'log_id' from backup filename: {file_name:?}. \
Error: {err:?}"
);
return Err(());
}
};
let additional_data = captures
.name("additional_data")
.map(|m| m.as_str().to_string());
Ok(Self {
backup_id,
log_id,
additional_data,
})
}
}
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

shared/protos/identity_unauth.proto

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs.flow

Loading...