Page MenuHomePhabricator
Differential D11399

[identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
ClosedPublic
Actions

Authored by varun on Mar 27 2024, 12:36 PM.
Tags
None
Referenced Files
F3386189: D11399.diff
Fri, Nov 29, 3:38 AM
Unknown Object (File)
Wed, Nov 13, 1:19 AM
Unknown Object (File)
Tue, Nov 12, 11:38 PM
Unknown Object (File)
Mon, Nov 4, 1:04 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:47 PM
Unknown Object (File)
Oct 22 2024, 2:44 PM
Unknown Object (File)
Oct 11 2024, 11:31 AM
View All 46 Files
Subscribers
tomek

Details

Reviewers
bartek
ashoat
Commits
rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs
Summary

.proto and grpc-web codegen changes. also added "unimplemented" gRPC handler methods to identity service

Depends on D11398

Test Plan

tested in subsequent diffs by calling the RPCs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 27 2024, 12:36 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 27 2024, 12:36 PM
varun added a child revision: D11400: [terraform] add GSI for farcasterID.Mar 27 2024, 12:39 PM
Harbormaster completed remote builds in B27714: Diff 38377.Mar 27 2024, 12:51 PM
varun requested review of this revision.Mar 27 2024, 12:51 PM
ashoat accepted this revision.Mar 27 2024, 5:21 PM
ashoat added inline comments.
shared/protos/identity_unauth.proto
293 ↗(On Diff #38377)

Note to @bartek – @varun and I discussed this online and our thinking was that Ethereum users would have their wallet address here. This is similar to the approach I proposed in D11379

bartek accepted this revision.Mar 27 2024, 10:26 PM
This revision is now accepted and ready to land.Mar 27 2024, 10:26 PM
Closed by commit rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs (authored by varun). · Explain WhyMar 28 2024, 2:55 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMcbdd966e6c5f: [identity][proto] add GetFarcasterUsers and LinkFarcasterAccount rpcs.

Revision Contents
Changeset List

Diff 38497

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

shared/protos/identity_auth.proto

Loading...
View Options

shared/protos/identity_unauth.proto

Loading...
View Options

web/protobufs/identity-auth-client.cjs

Loading...
View Options

web/protobufs/identity-auth-client.cjs.flow

Loading...
View Options

web/protobufs/identity-auth-structs.cjs

Loading...
View Options

web/protobufs/identity-auth-structs.cjs.flow

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs

Loading...
View Options

web/protobufs/identity-unauth-structs.cjs.flow

Loading...
View Options

web/protobufs/identity-unauth.cjs

Loading...
View Options

web/protobufs/identity-unauth.cjs.flow

Loading...