Page MenuHomePhabricator
Differential D11605

[lib] Re-introduce `RelationshipRequest` and replace `TraditionalRelationshipRequest` where simple
ClosedPublic
Actions

Authored by atul on Apr 9 2024, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 7:40 AM
Unknown Object (File)
Mon, Apr 22, 6:56 PM
Unknown Object (File)
Sun, Apr 21, 8:35 PM
Unknown Object (File)
Sun, Apr 21, 5:14 PM
Unknown Object (File)
Sun, Apr 21, 9:36 AM
Unknown Object (File)
Thu, Apr 18, 3:19 PM
Unknown Object (File)
Thu, Apr 18, 1:34 PM
Unknown Object (File)
Thu, Apr 18, 12:33 PM
View All 16 Files
Subscribers
ashoat

Details

Reviewers
varun
ginsu
will
tomek
Commits
rCOMMeef5dc5615bc: [lib] Re-introduce `RelationshipRequest` and replace…
Summary

Re-introduce RelationshipRequest as union of TraditionalRelationshipRequest|FarcasterRelationship and replace TraditionalRelationshipRequest where simple.

Next steps are to

  1. Narrow TraditionalRelationshipRequest so it excludes farcaster action
  2. Update FarcasterRelationshipRequest callsite
  3. Make necessary changes on keyserver to accomodate

Depends on D11603

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 9 2024, 8:06 PM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 9 2024, 8:06 PM
atul updated this revision to Diff 38962.Apr 9 2024, 8:07 PM

fix

Harbormaster failed remote builds in B28105: Diff 38961!Apr 9 2024, 8:18 PM
Harbormaster completed remote builds in B28106: Diff 38962.Apr 9 2024, 8:23 PM
atul requested review of this revision.Apr 9 2024, 8:23 PM
atul added a child revision: D11606: [lib] Update `FarcasterDataHandler` to construct `FarcasterRelationshipRequest` with `userIDsToFID`.Apr 9 2024, 8:49 PM
ginsu accepted this revision.Apr 9 2024, 10:07 PM
This revision is now accepted and ready to land.Apr 9 2024, 10:07 PM
atul updated this revision to Diff 38999.Apr 10 2024, 11:53 AM

land

This revision was landed with ongoing or failed builds.Apr 10 2024, 11:54 AM
Closed by commit rCOMMeef5dc5615bc: [lib] Re-introduce `RelationshipRequest` and replace… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMeef5dc5615bc: [lib] Re-introduce `RelationshipRequest` and replace….
Harbormaster completed remote builds in B28134: Diff 38999.Apr 10 2024, 12:10 PM

Revision Contents
Changeset List

PathSize
lib/
actions/
6 lines
types/
4 lines
native/
profile/
4 lines

Diff 38962

View Options

lib/actions/relationship-actions.js

Loading...
View Options

lib/types/relationship-types.js

Loading...
View Options

native/profile/relationship-list-item.react.js

Loading...