Now that we may get userIDsToFID instead of userIDs, we need to transform back to list of userIDs via Object.keys to maintain existing behavior.
Depends on D11606
Details
Details
- Set breakpoints and add log statements to ensure that userIDs gets constructed as expected for both traditional and farcaster relationship requests.
- Check keyserverDB to ensure that threads are created as expected
(need to go through again before landing)
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/src/updaters/relationship-updaters.js | ||
|---|---|---|
| 337–339 ↗ | (On Diff #38966) | How about checking the type property? |
| keyserver/src/updaters/relationship-updaters.js | ||
|---|---|---|
| 337–339 ↗ | (On Diff #38966) | Tried this initially, but flow wasn't able to figure out that FARCASTER_MUTUAL requests have userIDsToFID and the rest have userIDs  |
Comment Actions
This diff is safe to land as is as it broadens what arguments createPersonalThreads can accept and TraditionalRelationshipRequests will continue to work as expected.