Paths

Table of Contentst

[keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster` action
ClosedPublic
Actions

Authored by atul on Apr 9 2024, 9:53 PM.

Details

Reviewers

ginsu
tomek
varun
will

Commits

rCOMM8eef17ad3a41: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster`…

Summary

Modify updateRelationshipInputValidator so action is an enum of traditionalRelationshipActionsList vs relationshipActionsList.

Depends on D11609

Test Plan

Tried making request with farcaster action and it failed as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 9 2024, 9:53 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 9 2024, 9:53 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 9 2024, 9:55 PM

Harbormaster failed remote builds in B28112: Diff 38968!

atul added a child revision: D11611: [keyserver] Update `updateRelationshipsResponder` to handle `RelationshipRequest`.Apr 9 2024, 10:11 PM

atul requested review of this revision.Apr 10 2024, 8:09 AM

Harbormaster completed remote builds in B28112: Diff 38968.Apr 10 2024, 10:03 AM

rebasing

Harbormaster completed remote builds in B28139: Diff 39007.Apr 10 2024, 12:40 PM

tomek accepted this revision.Apr 11 2024, 2:24 AM

tomek added inline comments.

keyserver/src/responders/relationship-responders.js
17–20 ↗	(On Diff #39007)	Does that mean it's not possible to update Farcaster relationship?

This revision is now accepted and ready to land.Apr 11 2024, 2:24 AM

atul added inline comments.Apr 18 2024, 1:18 PM

keyserver/src/responders/relationship-responders.js
17–20 ↗	(On Diff #39007)	It will be via `FarcasterRelationshipRequest`, just not with `TraditionalRelationshipRequest`.

rebase and land

This revision was landed with ongoing or failed builds.Apr 18 2024, 1:26 PM

Closed by commit rCOMM8eef17ad3a41: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster`… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM8eef17ad3a41: [keyserver] Narrow `updateRelationshipInputValidator` to exclude `farcaster`….

Harbormaster completed remote builds in B28309: Diff 39250.Apr 18 2024, 1:56 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

relationship-responders.js

7 lines

lib/

types/

relationship-types.js

2 lines

Diff 38968

View Options

keyserver/src/responders/relationship-responders.js