Pretty self explanatory, we want to include these in content column so we can reconstruct rawMessageInfo from both client and serverDB.
Depends on D11650
Details
Details
Will create UPDATE_RELATIONSHIP message with operation = 'farcaster_mutual' and observe that row in messages table is correctly constructed before landing.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/messages/update-relationship-message-spec.js | ||
|---|---|---|
| 66 | Do we have to check this condition? | |
| lib/shared/messages/update-relationship-message-spec.js | ||
|---|---|---|
| 66 | Yeah, the reason we need to check this is because updateRelationshipMessageSpec is used for both LEGACY_UPDATE_RELATIONSHIP and UPDATE_RELATIONSHIP messages. | |
| lib/shared/messages/update-relationship-message-spec.js | ||
|---|---|---|
| 66 | JK, I think what you're saying is that data.operation === 'farcaster_mutual' would be a sufficient check since that implicitly tells us that the message type is UPDATE_RELATIONSHIP so having both is a bit redundant. Personally prefer including the first clause since it makes things more clear IMO, but can remove if others feel otherwise | |
| lib/shared/messages/update-relationship-message-spec.js | ||
|---|---|---|
| 66 | Ok, we can keep both conditions. | |