Page MenuHomePhabricator
Differential D12067

[native] Create initial device list during registration
ClosedPublic
Actions

Authored by bartek on May 16 2024, 12:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 8:05 AM
Unknown Object (File)
Sat, Nov 23, 8:04 AM
Unknown Object (File)
Sat, Nov 23, 5:37 AM
Unknown Object (File)
Sat, Nov 16, 4:08 PM
Unknown Object (File)
Mon, Nov 11, 11:03 AM
Unknown Object (File)
Mon, Nov 11, 7:53 AM
Unknown Object (File)
Mon, Nov 11, 6:52 AM
Unknown Object (File)
Sun, Nov 10, 10:07 PM
View All 64 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
will
Commits
rCOMMbef077681f8b: [native] Create initial device list during registration
Summary
  • Extracted utility function to generate RawDeviceList from given list of devices and current timestamp.
  • Created a function to create and sign initial device list - it creates a singleton array [primaryDeviceID], then signs via Olm.
  • Called the function in registerWalletUser and registerPasswordUser functions of identityClient

Depends on D12066

Test Plan
  1. In Identity Service, printed the value of initial_device_list in RPC handlers
  2. Registered a password user and a wallet user
  3. Confirmed that device list JSON payload is printed in Identity

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.May 16 2024, 12:00 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 16 2024, 12:00 AM
Harbormaster completed remote builds in B28974: Diff 40277.May 16 2024, 12:16 AM
bartek published this revision for review.May 16 2024, 12:53 AM
bartek added inline comments.
lib/shared/device-list-utils.js
124 ↗(On Diff #40277)

Not sure if this is the best place for this function, it is going to be called only on native.

kamil accepted this revision.May 16 2024, 1:58 AM
kamil added inline comments.
lib/shared/device-list-utils.js
124 ↗(On Diff #40277)

I think it's okay - this function is implemented in a way that can be used on both platforms if ever needed.

This revision is now accepted and ready to land.May 16 2024, 1:58 AM
bartek added a child revision: D12089: [identity] Add function to verify initial device list.May 17 2024, 12:23 AM
bartek updated this revision to Diff 40323.May 17 2024, 5:38 AM

Rebase before landing

Harbormaster completed remote builds in B29014: Diff 40323.May 17 2024, 5:55 AM
Closed by commit rCOMMbef077681f8b: [native] Create initial device list during registration (authored by bartek). · Explain WhyMay 17 2024, 7:16 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMbef077681f8b: [native] Create initial device list during registration.
bartek mentioned this in D11910: [native] add reserved registration methods to IdentityServiceContextProvider.May 17 2024, 7:22 AM

Revision Contents
Changeset List

Diff 40334

View Options

lib/shared/device-list-utils.js

Loading...
View Options

lib/shared/device-list-utils.test.js

Loading...
View Options

lib/utils/device-list-utils.js

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...