Page MenuHomePhabricator
Differential D12075

[SQLite] remove `deviceID` param when getting all Outbound P2P messages
ClosedPublic
Actions

Authored by kamil on May 16 2024, 7:33 AM.
Tags
None
Referenced Files
F3366437: D12075.diff
Mon, Nov 25, 11:24 AM
F3361315: D12075.diff
Sun, Nov 24, 4:31 PM
Unknown Object (File)
Thu, Oct 31, 8:40 PM
Unknown Object (File)
Oct 14 2024, 4:58 PM
Unknown Object (File)
Oct 14 2024, 4:58 PM
Unknown Object (File)
Oct 14 2024, 4:57 PM
Unknown Object (File)
Sep 15 2024, 4:45 AM
Unknown Object (File)
Sep 4 2024, 4:18 AM
View All 39 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM20a9300d4d38: [SQLite] remove `deviceID` param when getting all Outbound P2P messages
Summary

There is no need to specify deviceID - we want to query and attempt to send all messages (usage later in the stack).

Depends on D12074

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Branch
publish-broadcasting-2
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
3 lines
3 lines
7 lines
web/
shared-worker/
_generated/
queries/
34 lines
types/
4 lines

Diff 40589

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...