Page MenuHomePhabricator
Differential D12121

[native] Expose LogOutSecondaryDevice RPC via JSI
ClosedPublic
Actions

Authored by bartek on May 20 2024, 5:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 11:22 AM
Unknown Object (File)
Mon, Nov 11, 6:09 AM
Unknown Object (File)
Sun, Nov 10, 10:07 PM
Unknown Object (File)
Sat, Nov 2, 12:35 AM
Unknown Object (File)
Oct 18 2024, 5:18 PM
Unknown Object (File)
Oct 18 2024, 12:03 PM
Unknown Object (File)
Oct 12 2024, 6:20 AM
Unknown Object (File)
Oct 2 2024, 5:25 PM
View All 46 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
will
Commits
rCOMMfa8a90e2267f: [native] Expose LogOutSecondaryDevice RPC via JSI
Summary

Added LogOutSecondaryDevice RPC to native_rust_library and CommRustModule

Depends on D12120

Test Plan

Native compiles. Tested together with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.May 20 2024, 5:55 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 20 2024, 5:55 AM
bartek added a child revision: D12122: [lib][native][web] Add LogOutSecondaryDevice RPC to identity client.May 20 2024, 6:01 AM
Harbormaster completed remote builds in B29058: Diff 40397.May 20 2024, 6:11 AM
bartek published this revision for review.May 20 2024, 6:26 AM
kamil accepted this revision.May 23 2024, 2:39 AM
kamil added inline comments.
native/native_rust_library/src/identity/account_actions.rs
221

is there any benefit of doing this here, not like we are doing right now where each RPC has its own helper function?

This revision is now accepted and ready to land.May 23 2024, 2:39 AM
bartek added inline comments.May 28 2024, 4:39 AM
native/native_rust_library/src/identity/account_actions.rs
221

Just to avoid code duplication. This RPC is so simple (no inputs/outputs besides auth metadata) that it's worth doing it this way

Closed by commit rCOMMfa8a90e2267f: [native] Expose LogOutSecondaryDevice RPC via JSI (authored by bartek). · Explain WhyMay 28 2024, 5:42 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMfa8a90e2267f: [native] Expose LogOutSecondaryDevice RPC via JSI.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
5 lines
27 lines
_generated/
native_rust_library/
src/
identity/
37 lines
8 lines
schema/
5 lines

Diff 40397

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/native_rust_library/src/identity/account_actions.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...