Page MenuHomePhabricator
Differential D12122

[lib][native][web] Add LogOutSecondaryDevice RPC to identity client
ClosedPublic
Actions

Authored by bartek on May 20 2024, 6:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 2:04 PM
Unknown Object (File)
Wed, Apr 16, 1:06 PM
Unknown Object (File)
Wed, Apr 16, 7:31 AM
Unknown Object (File)
Tue, Apr 15, 11:39 PM
Unknown Object (File)
Tue, Apr 15, 10:49 AM
Unknown Object (File)
Mon, Apr 7, 8:18 AM
Unknown Object (File)
Thu, Apr 3, 11:09 PM
Unknown Object (File)
Tue, Apr 1, 4:48 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
kamil
will
Commits
rCOMMfa756c93c57b: [lib][native][web] Add LogOutSecondaryDevice RPC to identity client
Summary

Added LogOutSecondaryDevice to Identity client on web and native.
The RPC is described in ENG-5293 as a part of the "CSAT invalidation flow".

Depends on D12121

Test Plan
  • Registered a user (Identity-auto created device list with primary device).
  • Logged in with a second device (secondary device added to the list)
  • Called the RPC on the secondary device
    • Confirmed that CSAT as well as device keys were cleared by viewing DDB tables
    • Confirmed that the device ID still exists on the device list

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 40687

View Options

lib/types/identity-service-types.js

Show All 12 Lines
import ReportHandler from './report-handler.react.js'; import ReportHandler from './report-handler.react.js';
import RequestResponseHandler from './request-response-handler.react.js'; import RequestResponseHandler from './request-response-handler.react.js';
import UpdateHandler from './update-handler.react.js'; import UpdateHandler from './update-handler.react.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js'; import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js'; import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js';
import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js';
import type { InitialNotifMessageOptions } from '../shared/crypto-utils.js';
import { import {
pingFrequency, pingFrequency,
serverRequestSocketTimeout, serverRequestSocketTimeout,
clientRequestVisualTimeout, clientRequestVisualTimeout,
clientRequestSocketTimeout, clientRequestSocketTimeout,
} from '../shared/timeouts.js'; } from '../shared/timeouts.js';
import { logInActionSources } from '../types/account-types.js'; import { logInActionSources } from '../types/account-types.js';
import type { CompressedData } from '../types/compression-types.js'; import type { CompressedData } from '../types/compression-types.js';
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Linestype Props = {
+lastCommunicatedPlatformDetails: ?PlatformDetails, +lastCommunicatedPlatformDetails: ?PlatformDetails,
+decompressSocketMessage: CompressedData => string, +decompressSocketMessage: CompressedData => string,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
+dispatchActionPromise: DispatchActionPromise, +dispatchActionPromise: DispatchActionPromise,
// async functions that hit server APIs // async functions that hit server APIs
+socketCrashLoopRecovery?: () => Promise<void>, +socketCrashLoopRecovery?: () => Promise<void>,
// keyserver olm sessions specific props // keyserver olm sessions specific props
+getInitialNotificationsEncryptedMessage?: () => Promise<string>, +getInitialNotificationsEncryptedMessage?: (
options?: ?InitialNotifMessageOptions,
) => Promise<string>,
}; };
type State = { type State = {
+inflightRequests: ?InflightRequests, +inflightRequests: ?InflightRequests,
}; };
class Socket extends React.PureComponent<Props, State> { class Socket extends React.PureComponent<Props, State> {
state: State = { state: State = {
inflightRequests: null, inflightRequests: null,
}; };
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

native/identity-service/identity-service-context-provider.react.js

Show All 12 Lines
import ReportHandler from './report-handler.react.js'; import ReportHandler from './report-handler.react.js';
import RequestResponseHandler from './request-response-handler.react.js'; import RequestResponseHandler from './request-response-handler.react.js';
import UpdateHandler from './update-handler.react.js'; import UpdateHandler from './update-handler.react.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js'; import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js'; import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js';
import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js';
import type { InitialNotifMessageOptions } from '../shared/crypto-utils.js';
import { import {
pingFrequency, pingFrequency,
serverRequestSocketTimeout, serverRequestSocketTimeout,
clientRequestVisualTimeout, clientRequestVisualTimeout,
clientRequestSocketTimeout, clientRequestSocketTimeout,
} from '../shared/timeouts.js'; } from '../shared/timeouts.js';
import { logInActionSources } from '../types/account-types.js'; import { logInActionSources } from '../types/account-types.js';
import type { CompressedData } from '../types/compression-types.js'; import type { CompressedData } from '../types/compression-types.js';
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Linestype Props = {
+lastCommunicatedPlatformDetails: ?PlatformDetails, +lastCommunicatedPlatformDetails: ?PlatformDetails,
+decompressSocketMessage: CompressedData => string, +decompressSocketMessage: CompressedData => string,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
+dispatchActionPromise: DispatchActionPromise, +dispatchActionPromise: DispatchActionPromise,
// async functions that hit server APIs // async functions that hit server APIs
+socketCrashLoopRecovery?: () => Promise<void>, +socketCrashLoopRecovery?: () => Promise<void>,
// keyserver olm sessions specific props // keyserver olm sessions specific props
+getInitialNotificationsEncryptedMessage?: () => Promise<string>, +getInitialNotificationsEncryptedMessage?: (
options?: ?InitialNotifMessageOptions,
) => Promise<string>,
}; };
type State = { type State = {
+inflightRequests: ?InflightRequests, +inflightRequests: ?InflightRequests,
}; };
class Socket extends React.PureComponent<Props, State> { class Socket extends React.PureComponent<Props, State> {
state: State = { state: State = {
inflightRequests: null, inflightRequests: null,
}; };
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

web/grpc/identity-service-client-wrapper.js

Show All 12 Lines
import ReportHandler from './report-handler.react.js'; import ReportHandler from './report-handler.react.js';
import RequestResponseHandler from './request-response-handler.react.js'; import RequestResponseHandler from './request-response-handler.react.js';
import UpdateHandler from './update-handler.react.js'; import UpdateHandler from './update-handler.react.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js'; import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js'; import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js';
import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js';
import type { InitialNotifMessageOptions } from '../shared/crypto-utils.js';
import { import {
pingFrequency, pingFrequency,
serverRequestSocketTimeout, serverRequestSocketTimeout,
clientRequestVisualTimeout, clientRequestVisualTimeout,
clientRequestSocketTimeout, clientRequestSocketTimeout,
} from '../shared/timeouts.js'; } from '../shared/timeouts.js';
import { logInActionSources } from '../types/account-types.js'; import { logInActionSources } from '../types/account-types.js';
import type { CompressedData } from '../types/compression-types.js'; import type { CompressedData } from '../types/compression-types.js';
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Linestype Props = {
+lastCommunicatedPlatformDetails: ?PlatformDetails, +lastCommunicatedPlatformDetails: ?PlatformDetails,
+decompressSocketMessage: CompressedData => string, +decompressSocketMessage: CompressedData => string,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
+dispatchActionPromise: DispatchActionPromise, +dispatchActionPromise: DispatchActionPromise,
// async functions that hit server APIs // async functions that hit server APIs
+socketCrashLoopRecovery?: () => Promise<void>, +socketCrashLoopRecovery?: () => Promise<void>,
// keyserver olm sessions specific props // keyserver olm sessions specific props
+getInitialNotificationsEncryptedMessage?: () => Promise<string>, +getInitialNotificationsEncryptedMessage?: (
options?: ?InitialNotifMessageOptions,
) => Promise<string>,
}; };
type State = { type State = {
+inflightRequests: ?InflightRequests, +inflightRequests: ?InflightRequests,
}; };
class Socket extends React.PureComponent<Props, State> { class Socket extends React.PureComponent<Props, State> {
state: State = { state: State = {
inflightRequests: null, inflightRequests: null,
}; };
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines
View Options

web/grpc/identity-service-context-provider.react.js

Show All 12 Lines
import ReportHandler from './report-handler.react.js'; import ReportHandler from './report-handler.react.js';
import RequestResponseHandler from './request-response-handler.react.js'; import RequestResponseHandler from './request-response-handler.react.js';
import UpdateHandler from './update-handler.react.js'; import UpdateHandler from './update-handler.react.js';
import { updateActivityActionTypes } from '../actions/activity-actions.js'; import { updateActivityActionTypes } from '../actions/activity-actions.js';
import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js'; import { updateLastCommunicatedPlatformDetailsActionType } from '../actions/device-actions.js';
import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js'; import { setNewSessionActionType } from '../keyserver-conn/keyserver-conn-types.js';
import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js'; import { resolveKeyserverSessionInvalidation } from '../keyserver-conn/recovery-utils.js';
import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js'; import { unsupervisedBackgroundActionType } from '../reducers/lifecycle-state-reducer.js';
import type { InitialNotifMessageOptions } from '../shared/crypto-utils.js';
import { import {
pingFrequency, pingFrequency,
serverRequestSocketTimeout, serverRequestSocketTimeout,
clientRequestVisualTimeout, clientRequestVisualTimeout,
clientRequestSocketTimeout, clientRequestSocketTimeout,
} from '../shared/timeouts.js'; } from '../shared/timeouts.js';
import { logInActionSources } from '../types/account-types.js'; import { logInActionSources } from '../types/account-types.js';
import type { CompressedData } from '../types/compression-types.js'; import type { CompressedData } from '../types/compression-types.js';
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Linestype Props = {
+lastCommunicatedPlatformDetails: ?PlatformDetails, +lastCommunicatedPlatformDetails: ?PlatformDetails,
+decompressSocketMessage: CompressedData => string, +decompressSocketMessage: CompressedData => string,
// Redux dispatch functions // Redux dispatch functions
+dispatch: Dispatch, +dispatch: Dispatch,
+dispatchActionPromise: DispatchActionPromise, +dispatchActionPromise: DispatchActionPromise,
// async functions that hit server APIs // async functions that hit server APIs
+socketCrashLoopRecovery?: () => Promise<void>, +socketCrashLoopRecovery?: () => Promise<void>,
// keyserver olm sessions specific props // keyserver olm sessions specific props
+getInitialNotificationsEncryptedMessage?: () => Promise<string>, +getInitialNotificationsEncryptedMessage?: (
options?: ?InitialNotifMessageOptions,
) => Promise<string>,
}; };
type State = { type State = {
+inflightRequests: ?InflightRequests, +inflightRequests: ?InflightRequests,
}; };
class Socket extends React.PureComponent<Props, State> { class Socket extends React.PureComponent<Props, State> {
state: State = { state: State = {
inflightRequests: null, inflightRequests: null,
}; };
▲ Show 20 Lines • Show All 698 Lines • Show Last 20 Lines