Page MenuHomePhabricator
Differential D12422

[web][native] Display both thread and community names in the modal
ClosedPublic
Actions

Authored by tomek on Jun 13 2024, 5:23 AM.
Tags
None
Referenced Files
F3381852: D12422.diff
Thu, Nov 28, 6:47 AM
Unknown Object (File)
Sun, Nov 24, 9:55 PM
Unknown Object (File)
Mon, Nov 18, 1:24 AM
Unknown Object (File)
Sat, Nov 16, 6:29 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
Unknown Object (File)
Fri, Nov 1, 8:16 PM
View All 59 Files
Subscribers
None

Details

Reviewers
inka
ginsu
ashoat
Commits
rCOMM56ba1a3c7ec6: [web][native] Display both thread and community names in the modal
Summary

Display both a community and thread names when a link points at a thread. Show just the community name for community links.

https://linear.app/comm/issue/ENG-8417/show-a-thread-name-to-which-a-link-points-in-the-modal

Web

web_community_link.png (714×932 px, 46 KB)

web_thread_link.png (918×952 px, 55 KB)

Native

native_community_link.png (303×378 px, 18 KB)

native_thread_link.png (392×386 px, 22 KB)

Long names, e.g. A thread with a long name containing words with a lot of characters like aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa:

native_long.png (616×377 px, 43 KB)

web_long.png (1×938 px, 112 KB)

Depends on D12421

Test Plan

Checked on both platforms and for both link types that the names are displayed correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jun 13 2024, 5:23 AM
tomek edited the summary of this revision. (Show Details)Jun 13 2024, 5:29 AM
tomek added a child revision: D12423: [lib] Modify the approach to handling invite link acceptance.Jun 13 2024, 5:34 AM
Harbormaster completed remote builds in B29654: Diff 41277.Jun 13 2024, 5:40 AM
tomek requested review of this revision.Jun 13 2024, 5:40 AM
ashoat accepted this revision.Jun 13 2024, 11:17 AM

How does it look if the names are really long?

This revision is now accepted and ready to land.Jun 13 2024, 11:17 AM
tomek planned changes to this revision.EditedJun 14 2024, 3:16 AM
In D12422#352779, @ashoat wrote:

How does it look if the names are really long?

Good call! It doesn't handle it well on web - going to update the diff.

tomek updated this revision to Diff 41320.EditedJun 14 2024, 3:29 AM

Handle long names on web. Updated the summary with some screenshots.

This revision is now accepted and ready to land.Jun 14 2024, 3:29 AM
tomek edited the summary of this revision. (Show Details)Jun 14 2024, 3:29 AM
Harbormaster completed remote builds in B29681: Diff 41320.Jun 14 2024, 3:45 AM
Closed by commit rCOMM56ba1a3c7ec6: [web][native] Display both thread and community names in the modal (authored by tomek). · Explain WhyJun 14 2024, 5:27 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM56ba1a3c7ec6: [web][native] Display both thread and community names in the modal.
inka added a comment.Jun 24 2024, 1:05 AM

"within" is not centered on web (vertically), can we fix this?

tomek added a comment.Jul 5 2024, 4:36 AM
In D12422#355471, @inka wrote:

"within" is not centered on web (vertically), can we fix this?

Created https://linear.app/comm/issue/ENG-8728/fix-the-styling-of-invite-link-modal-on-web to track

Revision Contents
Changeset List

PathSize
native/
navigation/
32 lines
web/
invite-links/
18 lines

Diff 41277

View Options

native/navigation/invite-link-modal.react.js

Loading...
View Options

web/invite-links/accept-invite-modal.react.js

Loading...