Nit: I figure we can leave badgeOnly around since we use it from the notifs code, but the badgeCount and BADGE_COUNT stuff could be renamed for consistency

native/chat/settings/thread-settings-notifications.react.js
89–94	Should this be renamed?
110	Should this be renamed?

This revision is now accepted and ready to land.Jul 4 2024, 1:31 PM

address comments + rebase before landing

This revision was landed with ongoing or failed builds.Jul 4 2024, 6:21 PM

Closed by commit rCOMM17786b62ab07: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT. · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM17786b62ab07: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT.

Harbormaster completed remote builds in B30166: Diff 42058.Jul 4 2024, 7:01 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-settings-notifications-utils.js

2 lines

native/

chat/

settings/

thread-settings-notifications.react.js

2 lines

web/

modals/

threads/

notifications/

notifications-modal.react.js

6 lines

Diff 41999

View Options

lib/shared/thread-settings-notifications-utils.js

View Options

native/chat/settings/thread-settings-notifications.react.js

View Options

web/modals/threads/notifications/notifications-modal.react.js

[lib/native/web] update copy BADGE_COUNT => NOTIF_COUNTClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41999

lib/shared/thread-settings-notifications-utils.js

native/chat/settings/thread-settings-notifications.react.js

web/modals/threads/notifications/notifications-modal.react.js

[lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT
ClosedPublic
Actions

Revision Contents
Changeset List