Page MenuHomePhabricator
Differential D12979

[native] Move buttonStyle
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 1:21 PM
Unknown Object (File)
Sun, Sep 8, 4:29 AM
Unknown Object (File)
Thu, Sep 5, 3:52 PM
Unknown Object (File)
Thu, Sep 5, 3:52 PM
Unknown Object (File)
Thu, Sep 5, 3:51 PM
Unknown Object (File)
Thu, Sep 5, 11:21 AM
Unknown Object (File)
Wed, Sep 4, 7:56 PM
Unknown Object (File)
Tue, Sep 3, 1:59 PM
View All 43 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMe8fce78e4e69: [native] Move buttonStyle
Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Aug 5 2024, 6:03 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:03 AM
inka added a parent revision: D12978: [native] Move opacityStyle.Aug 5 2024, 6:11 AM
inka added a child revision: D12980: [native] Move onTipContainerLayout.
Harbormaster completed remote builds in B30926: Diff 43114.Aug 5 2024, 8:14 AM
inka requested review of this revision.Aug 5 2024, 8:14 AM
tomek accepted this revision.Aug 6 2024, 2:20 AM
tomek added inline comments.
native/tooltip/nux-tips-overlay.react.js
309 ↗(On Diff #43114)

We can make this a little more efficient by using more specific dependencies (initialCoordinates and verticalBounds).

This revision is now accepted and ready to land.Aug 6 2024, 2:20 AM
inka updated this revision to Diff 43343.Aug 13 2024, 6:37 AM

Address review

Harbormaster completed remote builds in B31065: Diff 43343.Aug 13 2024, 6:54 AM
Closed by commit rCOMMe8fce78e4e69: [native] Move buttonStyle (authored by inka). · Explain WhyAug 13 2024, 7:46 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMe8fce78e4e69: [native] Move buttonStyle.

Revision Contents
Changeset List

PathSize
native/
tooltip/
29 lines

Diff 43352

View Options

native/tooltip/nux-tips-overlay.react.js

Loading...