Page MenuHomePhabricator
Differential D13065

[native] Simplify types
ClosedPublic
Actions

Authored by inka on Aug 13 2024, 8:26 AM.
Tags
None
Referenced Files
F5118209: D13065.diff
Wed, Apr 2, 11:13 PM
F5116560: D13065.diff
Wed, Apr 2, 3:28 PM
Unknown Object (File)
Thu, Mar 13, 6:09 PM
Unknown Object (File)
Fri, Mar 7, 1:39 AM
Unknown Object (File)
Wed, Mar 5, 2:55 PM
Unknown Object (File)
Tue, Mar 4, 11:01 PM
Unknown Object (File)
Mar 3 2025, 6:20 AM
Unknown Object (File)
Feb 28 2025, 11:55 AM
View All 92 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM5c1b9d97b69a: [native] Simplify types
Summary

issue: ENG-9814
I don't need to pass progress to the button components. This is needed for example in text message so that it can move to the right space after being pressed (in oreder to display tooltip). The nux tips don't need this

Test Plan

N/A - this code isn't being used anywhere yet, and the change is very simple

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
tooltip/
22 lines

Diff 43478

View Options

native/tooltip/nux-tips-overlay.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js'; import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js';
import ChatContextProvider from './chat/chat-context-provider.react.js'; import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js'; import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js'; import AccessTokenHandler from './components/access-token-handler.react.js';
import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js'; import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js';
import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js'; import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js';
import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js'; import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js'; import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
import { NUXTipsContextProvider } from './components/nux-tips-context.react.js';
import PersistedStateGate from './components/persisted-state-gate.js'; import PersistedStateGate from './components/persisted-state-gate.js';
import ReportHandler from './components/report-handler.react.js'; import ReportHandler from './components/report-handler.react.js';
import VersionSupportedChecker from './components/version-supported.react.js'; import VersionSupportedChecker from './components/version-supported.react.js';
import ConnectedStatusBar from './connected-status-bar.react.js'; import ConnectedStatusBar from './connected-status-bar.react.js';
import { SQLiteDataHandler } from './data/sqlite-data-handler.js'; import { SQLiteDataHandler } from './data/sqlite-data-handler.js';
import ErrorBoundary from './error-boundary.react.js'; import ErrorBoundary from './error-boundary.react.js';
import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js'; import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
▲ Show 20 Lines • Show All 233 Lines • ▼ Show 20 Lines navigation = (
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider> <ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<ChatMentionContextProvider> <ChatMentionContextProvider>
<NUXTipsContextProvider>
<RootNavigator /> <RootNavigator />
</NUXTipsContextProvider>
</ChatMentionContextProvider> </ChatMentionContextProvider>
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider> </ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
<PersistedStateGate> <PersistedStateGate>
<FarcasterDataHandler> <FarcasterDataHandler>
<ConnectFarcasterAlertHandler /> <ConnectFarcasterAlertHandler />
</FarcasterDataHandler> </FarcasterDataHandler>
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines