issue: ENG-8542
We need to be able to display the button without it navigating to the drawer and without the effect being run
Details
Details
Tested that the community drawer button looks like it used to. Tested with later diffs that the tip works correctly
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Rename
| native/navigation/community-drawer-button-base.react.js | ||
|---|---|---|
| 9 ↗ | (On Diff #43384) |
Because ButtonComponent is typed as React.ComponentType<NUXTipsOverlayProps<Route>>, Cannot call createNUXTipsOverlay with CommunityDrawerButtonIcon bound to ButtonComponent because property route is
missing in function type [1] but exists in props [2]. [prop-missing]
navigation/community-drawer-tip.react.js
15│
16│ const CommunityDrawerTip: React.ComponentType<
17│ NUXTipsOverlayProps<'CommunityDrawerTip'>,
18│ > = createNUXTipsOverlay(CommunityDrawerButtonIcon, communityDrawerText);
19│
20│ export default CommunityDrawerTip;
21│
navigation/community-drawer-button-icon.react.js
[1] 8│ export default function CommunityDrawerButtonIcon(): React.Node {
tooltip/nux-tips-overlay.react.js
[2] 124│ ButtonComponent: React.ComponentType<void | NUXTipsOverlayProps<Route>>, |
| native/navigation/community-drawer-button-base.react.js | ||
|---|---|---|
| 9 ↗ | (On Diff #43384) | Makes sense! How about having an exact type with route and navigation? |
| native/navigation/community-drawer-button-base.react.js | ||
|---|---|---|
| 9 ↗ | (On Diff #43384) | Then I would have to pass them creating more useless code, and the eslint-disable-next-line would still have to be here. What for? |
| native/navigation/community-drawer-button-base.react.js | ||
|---|---|---|
| 9 ↗ | (On Diff #43384) | Ok, let's keep the current approach. |
Comment Actions
Let's make sure to always use proper apostrophes in copy instead of single quotes
| native/navigation/community-drawer-tip.react.js | ||
|---|---|---|
| 14 ↗ | (On Diff #43473) | Can we use a proper apostrophe character instead of a single quote here? I mean this character: ’ Rather than this character: ' |