Page MenuHomePhabricator
Differential D13063

[native] Simplify name
ClosedPublic
Actions

Authored by inka on Aug 13 2024, 8:06 AM.
Tags
None
Referenced Files
F5118217: D13063.diff
Wed, Apr 2, 11:14 PM
Unknown Object (File)
Tue, Mar 4, 10:13 PM
Unknown Object (File)
Tue, Mar 4, 7:59 PM
Unknown Object (File)
Mar 3 2025, 6:20 AM
Unknown Object (File)
Mar 3 2025, 6:20 AM
Unknown Object (File)
Feb 28 2025, 11:55 AM
Unknown Object (File)
Feb 28 2025, 11:55 AM
Unknown Object (File)
Feb 10 2025, 8:31 PM
View All 85 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMd024104db519: [native] Simplify name
Summary

issue: ENG-8914
The name doesn't have to be this complicated

Test Plan

ted that the component can still be rendered

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Aug 13 2024, 8:06 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 13 2024, 8:06 AM
inka added a parent revision: D13062: [native] Turn MenuComponent into text.Aug 13 2024, 8:06 AM
inka added a child revision: D13064: [native] Modify overlay context to handle reanimated 2 components.Aug 13 2024, 8:23 AM
Harbormaster completed remote builds in B31072: Diff 43358.Aug 13 2024, 8:29 AM
inka requested review of this revision.Aug 13 2024, 8:29 AM
will accepted this revision.Aug 13 2024, 4:18 PM
This revision is now accepted and ready to land.Aug 13 2024, 4:18 PM
tomek accepted this revision.Aug 14 2024, 2:45 AM
tomek added inline comments.
native/tooltip/nux-tips-overlay.react.js
87 ↗(On Diff #43358)

It looks like we need to rebase this diff.

inka updated this revision to Diff 43447.Aug 19 2024, 4:59 AM

Rebase

Harbormaster completed remote builds in B31134: Diff 43447.Aug 19 2024, 5:16 AM
Closed by commit rCOMMd024104db519: [native] Simplify name (authored by inka). · Explain WhyAug 20 2024, 1:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMd024104db519: [native] Simplify name.

Revision Contents
Changeset List

PathSize
native/
tooltip/
4 lines

Diff 43476

View Options

native/tooltip/nux-tips-overlay.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js'; import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js';
import ChatContextProvider from './chat/chat-context-provider.react.js'; import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js'; import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js'; import AccessTokenHandler from './components/access-token-handler.react.js';
import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js'; import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js';
import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js'; import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js';
import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js'; import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js'; import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
import { NUXTipsContextProvider } from './components/nux-tips-context.react.js';
import PersistedStateGate from './components/persisted-state-gate.js'; import PersistedStateGate from './components/persisted-state-gate.js';
import ReportHandler from './components/report-handler.react.js'; import ReportHandler from './components/report-handler.react.js';
import VersionSupportedChecker from './components/version-supported.react.js'; import VersionSupportedChecker from './components/version-supported.react.js';
import ConnectedStatusBar from './connected-status-bar.react.js'; import ConnectedStatusBar from './connected-status-bar.react.js';
import { SQLiteDataHandler } from './data/sqlite-data-handler.js'; import { SQLiteDataHandler } from './data/sqlite-data-handler.js';
import ErrorBoundary from './error-boundary.react.js'; import ErrorBoundary from './error-boundary.react.js';
import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js'; import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
▲ Show 20 Lines • Show All 233 Lines • ▼ Show 20 Lines navigation = (
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider> <ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<ChatMentionContextProvider> <ChatMentionContextProvider>
<NUXTipsContextProvider>
<RootNavigator /> <RootNavigator />
</NUXTipsContextProvider>
</ChatMentionContextProvider> </ChatMentionContextProvider>
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider> </ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
<PersistedStateGate> <PersistedStateGate>
<FarcasterDataHandler> <FarcasterDataHandler>
<ConnectFarcasterAlertHandler /> <ConnectFarcasterAlertHandler />
</FarcasterDataHandler> </FarcasterDataHandler>
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines