Paths

Table of Contentst

Differential D13179

[native] Make possible to render tip not pointing to anything
ClosedPublic
Actions

Authored by inka on Tue, Aug 27, 10:03 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 18, 4:38 AM

	Unknown Object (File)
	Mon, Sep 16, 4:23 AM

	Unknown Object (File)
	Sun, Sep 15, 10:28 PM

	Unknown Object (File)
	Sat, Sep 14, 12:23 AM

	Unknown Object (File)
	Wed, Sep 11, 5:11 AM

	Unknown Object (File)
	Tue, Sep 10, 2:47 PM

	Unknown Object (File)
	Mon, Sep 9, 11:09 AM

	Unknown Object (File)
	Sun, Sep 8, 10:11 PM

View All 36 Files

Subscribers

Details

Reviewers

tomek
will

Commits

rCOMM0171af76e7be: [native] Make possible to render tip not pointing to anything

Summary

issue: ENG-9062
the intro tip will not be pointing to anything

Test Plan

tested with the next diff:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Tue, Aug 27, 10:03 AM

Herald added a subscriber: ashoat. · View Herald TranscriptTue, Aug 27, 10:03 AM

inka added a parent revision: D13177: [native] Create home tab tip.Tue, Aug 27, 10:04 AM

inka edited the test plan for this revision. (Show Details)

inka attached a referenced file: F2559097: Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-27 at 18.55.48.mp4. (Show Details)

inka added a child revision: D13180: [native] Create intro tip.Tue, Aug 27, 10:07 AM

Harbormaster completed remote builds in B31300: Diff 43701.Tue, Aug 27, 10:25 AM

inka requested review of this revision.Tue, Aug 27, 10:25 AM

tomek accepted this revision.Wed, Aug 28, 4:06 AM

tomek added inline comments.

native/tooltip/nux-tips-overlay.react.js
134–137 ↗	(On Diff #43701)	I guess you can have a single invariant for these

This revision is now accepted and ready to land.Wed, Aug 28, 4:06 AM

Address review

Harbormaster completed remote builds in B31326: Diff 43734.Wed, Aug 28, 4:38 AM

Closed by commit rCOMM0171af76e7be: [native] Make possible to render tip not pointing to anything (authored by inka). · Explain WhyThu, Aug 29, 6:44 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM0171af76e7be: [native] Make possible to render tip not pointing to anything.

Just some style nits. Please note that we need to handle styling ourselves inside of prettier-ignore

native/tooltip/nux-tips-overlay.react.js
321	The worklet has to be wrapped with `prettier-ignore` to avoid stripping the Flow comment annotations, but that means we have to handle the styling ourselves
331	Whitespace issue here too

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

75 lines

Diff 43806

native/tooltip/nux-tips-overlay.react.js

Loading...