Page MenuHomePhabricator
Differential D13136

[native] Fix blinking overlay background
ClosedPublic
Actions

Authored by inka on Aug 22 2024, 2:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 7:48 PM
Unknown Object (File)
Tue, Dec 10, 9:02 AM
Unknown Object (File)
Fri, Dec 6, 7:35 AM
Unknown Object (File)
Thu, Nov 28, 12:27 PM
Unknown Object (File)
Nov 12 2024, 5:41 PM
Unknown Object (File)
Nov 8 2024, 2:09 AM
Unknown Object (File)
Nov 8 2024, 2:09 AM
Unknown Object (File)
Nov 8 2024, 2:08 AM
View All 59 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM7519541150d4: [native] Fix blinking overlay background
Summary

issue: ENG-9058

Test Plan

Please see the video:

(this is with a sleep(2000) in the nux handler, because otherwise the tip gets dismissed for some reason. Created https://linear.app/comm/issue/ENG-9085/fix-tip-getting-dismissed to track

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Aug 22 2024, 2:37 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 2:37 AM
inka edited the test plan for this revision. (Show Details)Aug 22 2024, 2:42 AM
inka attached a referenced file: F2510688: Simulator Screen Recording - iPhone 15 Pro Max - 2024-08-22 at 11.12.27.mp4. (Show Details)
inka updated this revision to Diff 43567.Aug 22 2024, 2:48 AM

Rebase

Harbormaster completed remote builds in B31209: Diff 43565.Aug 22 2024, 2:55 AM
Harbormaster completed remote builds in B31211: Diff 43567.Aug 22 2024, 3:04 AM
inka requested review of this revision.Aug 22 2024, 3:04 AM
inka added a comment.Aug 22 2024, 3:31 AM

Turns out that the tip being dismissed is only happening after this diff. Trying to figure out why

inka added a parent revision: D13127: [native] Update styling.Aug 23 2024, 5:09 AM

Moved the handler in D13085, the tip is not dismissed anymore

tomek accepted this revision.Aug 23 2024, 5:17 AM
This revision is now accepted and ready to land.Aug 23 2024, 5:17 AM
inka added a child revision: D13176: [native] Fix light mode highlighting.Aug 27 2024, 7:39 AM
Closed by commit rCOMM7519541150d4: [native] Fix blinking overlay background (authored by inka). · Explain WhyAug 29 2024, 6:43 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM7519541150d4: [native] Fix blinking overlay background.

Revision Contents
Changeset List

Diff 43802

View Options

native/components/nux-handler.react.js

Loading...
View Options

native/components/nux-tips-context.react.js

Loading...
View Options

native/navigation/app-navigator.react.js

Loading...
View Options

native/navigation/nux-tip-overlay-backdrop.react.js

Loading...
View Options

native/navigation/overlay-navigator.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...
View Options

native/tooltip/nux-tips-overlay.react.js

Loading...