Page MenuHomePhabricator
Differential D12983

[native] Move tipContainerStyle
ClosedPublic
Actions

Authored by inka on Aug 5 2024, 6:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 7:58 AM
Unknown Object (File)
Wed, Mar 5, 2:57 AM
Unknown Object (File)
Wed, Mar 5, 1:38 AM
Unknown Object (File)
Tue, Mar 4, 6:32 PM
Unknown Object (File)
Feb 22 2025, 11:49 AM
Unknown Object (File)
Feb 17 2025, 11:51 PM
Unknown Object (File)
Feb 17 2025, 11:51 PM
Unknown Object (File)
Feb 17 2025, 11:51 PM
View All 83 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM0c9ed621cf86: [native] Move tipContainerStyle
Summary

issue: ENG-8914
Refactoring from class to function

Test Plan

Tested by creating a nux tooltip and displaying it - still works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Aug 5 2024, 6:09 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 6:09 AM
inka added a parent revision: D12982: [native] Move tipScale, tipHorizontal.Aug 5 2024, 6:12 AM
inka added a child revision: D12984: [native] Remove unused variables.
Harbormaster completed remote builds in B30931: Diff 43119.Aug 5 2024, 8:51 AM
inka requested review of this revision.Aug 5 2024, 8:51 AM
tomek accepted this revision.Aug 6 2024, 2:33 AM
tomek added inline comments.
native/tooltip/nux-tips-overlay.react.js
143–144 ↗(On Diff #43119)

After tipContainerStyle got moved, some of the props are no longer being used. I'm assuming it was done later in the stack.

340 ↗(On Diff #43119)
This revision is now accepted and ready to land.Aug 6 2024, 2:33 AM
tomek added inline comments.Aug 6 2024, 2:34 AM
native/tooltip/nux-tips-overlay.react.js
143–144 ↗(On Diff #43119)

It was done in D12985.

inka updated this revision to Diff 43354.Aug 13 2024, 7:51 AM

Address review

Harbormaster completed remote builds in B31068: Diff 43354.Aug 13 2024, 8:08 AM
Closed by commit rCOMM0c9ed621cf86: [native] Move tipContainerStyle (authored by inka). · Explain WhyAug 19 2024, 1:59 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM0c9ed621cf86: [native] Move tipContainerStyle.

Revision Contents
Changeset List

PathSize
native/
tooltip/
85 lines

Diff 43432

View Options

native/tooltip/nux-tips-overlay.react.js

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js'; import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js';
import ChatContextProvider from './chat/chat-context-provider.react.js'; import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js'; import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js'; import AccessTokenHandler from './components/access-token-handler.react.js';
import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js'; import { AutoJoinCommunityHandler } from './components/auto-join-community-handler.react.js';
import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js'; import BackgroundIdentityLoginHandler from './components/background-identity-login-handler.react.js';
import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js'; import ConnectFarcasterAlertHandler from './components/connect-farcaster-alert-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js'; import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
import { NUXTipsContextProvider } from './components/nux-tips-context.react.js';
import PersistedStateGate from './components/persisted-state-gate.js'; import PersistedStateGate from './components/persisted-state-gate.js';
import ReportHandler from './components/report-handler.react.js'; import ReportHandler from './components/report-handler.react.js';
import VersionSupportedChecker from './components/version-supported.react.js'; import VersionSupportedChecker from './components/version-supported.react.js';
import ConnectedStatusBar from './connected-status-bar.react.js'; import ConnectedStatusBar from './connected-status-bar.react.js';
import { SQLiteDataHandler } from './data/sqlite-data-handler.js'; import { SQLiteDataHandler } from './data/sqlite-data-handler.js';
import ErrorBoundary from './error-boundary.react.js'; import ErrorBoundary from './error-boundary.react.js';
import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js'; import IdentityServiceContextProvider from './identity-service/identity-service-context-provider.react.js';
import InputStateContainer from './input/input-state-container.react.js'; import InputStateContainer from './input/input-state-container.react.js';
▲ Show 20 Lines • Show All 233 Lines • ▼ Show 20 Lines navigation = (
onStateChange={onNavigationStateChange} onStateChange={onNavigationStateChange}
theme={theme} theme={theme}
ref={containerRef} ref={containerRef}
> >
<BottomSheetModalProvider> <BottomSheetModalProvider>
<ChatContextProvider> <ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<ChatMentionContextProvider> <ChatMentionContextProvider>
<NUXTipsContextProvider>
<RootNavigator /> <RootNavigator />
</NUXTipsContextProvider>
</ChatMentionContextProvider> </ChatMentionContextProvider>
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider> </ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
<PersistedStateGate> <PersistedStateGate>
<FarcasterDataHandler> <FarcasterDataHandler>
<ConnectFarcasterAlertHandler /> <ConnectFarcasterAlertHandler />
</FarcasterDataHandler> </FarcasterDataHandler>
▲ Show 20 Lines • Show All 106 Lines • Show Last 20 Lines