Page MenuHomePhabricator
Differential D13194

[native] Simplify nux tips props design
ClosedPublic
Actions

Authored by inka on Wed, Aug 28, 7:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 16, 1:42 PM
Unknown Object (File)
Sat, Sep 14, 12:02 PM
Unknown Object (File)
Thu, Sep 12, 1:01 PM
Unknown Object (File)
Wed, Sep 11, 12:14 PM
Unknown Object (File)
Mon, Sep 9, 6:16 PM
Unknown Object (File)
Mon, Sep 9, 10:26 AM
Unknown Object (File)
Mon, Sep 9, 10:02 AM
Unknown Object (File)
Sat, Sep 7, 4:22 PM
View All 28 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM480cb0e9128c: [native] Simplify nux tips props design
Summary

This improves code readability

Test Plan

tested that the tips show up correctly on first app launch

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Wed, Aug 28, 7:04 AM
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Aug 28, 7:04 AM
inka added a parent revision: D13180: [native] Create intro tip.Wed, Aug 28, 7:05 AM
inka mentioned this in D13180: [native] Create intro tip.Wed, Aug 28, 7:07 AM
Harbormaster completed remote builds in B31338: Diff 43748.Wed, Aug 28, 7:21 AM
inka requested review of this revision.Wed, Aug 28, 7:21 AM
tomek accepted this revision.Wed, Aug 28, 8:26 AM
tomek added inline comments.
native/components/nux-tips-context.react.js
35–37 ↗(On Diff #43748)

We can simplify it now

This revision is now accepted and ready to land.Wed, Aug 28, 8:26 AM
inka updated this revision to Diff 43791.Thu, Aug 29, 3:15 AM

Address review

inka added a child revision: D13206: [native] Hide nux behind a flag.Thu, Aug 29, 3:26 AM
Harbormaster completed remote builds in B31363: Diff 43791.Thu, Aug 29, 3:32 AM
Closed by commit rCOMM480cb0e9128c: [native] Simplify nux tips props design (authored by inka). · Explain WhyThu, Aug 29, 6:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM480cb0e9128c: [native] Simplify nux tips props design.

Revision Contents
Changeset List

PathSize
native/
components/
26 lines
navigation/
9 lines
tooltip/
22 lines

Diff 43808

View Options

native/components/nux-tips-context.react.js

Loading...
View Options

native/navigation/nux-tip-overlay-backdrop.react.js

Loading...
View Options

native/tooltip/nux-tips-overlay.react.js

Loading...