Page MenuHomePhabricator
Differential D13194

[native] Simplify nux tips props design
ClosedPublic
Actions

Authored by inka on Aug 28 2024, 7:04 AM.
Tags
None
Referenced Files
F3499950: D13194.diff
Fri, Dec 20, 12:40 AM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Wed, Dec 18, 3:11 PM
Unknown Object (File)
Fri, Dec 6, 2:53 PM
Unknown Object (File)
Nov 9 2024, 11:38 PM
View All 51 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMM480cb0e9128c: [native] Simplify nux tips props design
Summary

This improves code readability

Test Plan

tested that the tips show up correctly on first app launch

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Aug 28 2024, 7:04 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 7:04 AM
inka added a parent revision: D13180: [native] Create intro tip.Aug 28 2024, 7:05 AM
inka mentioned this in D13180: [native] Create intro tip.Aug 28 2024, 7:07 AM
Harbormaster completed remote builds in B31338: Diff 43748.Aug 28 2024, 7:21 AM
inka requested review of this revision.Aug 28 2024, 7:21 AM
tomek accepted this revision.Aug 28 2024, 8:26 AM
tomek added inline comments.
native/components/nux-tips-context.react.js
35–37 ↗(On Diff #43748)

We can simplify it now

This revision is now accepted and ready to land.Aug 28 2024, 8:26 AM
inka updated this revision to Diff 43791.Aug 29 2024, 3:15 AM

Address review

inka added a child revision: D13206: [native] Hide nux behind a flag.Aug 29 2024, 3:26 AM
Harbormaster completed remote builds in B31363: Diff 43791.Aug 29 2024, 3:32 AM
Closed by commit rCOMM480cb0e9128c: [native] Simplify nux tips props design (authored by inka). · Explain WhyAug 29 2024, 6:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM480cb0e9128c: [native] Simplify nux tips props design.

Revision Contents
Changeset List

PathSize
native/
components/
26 lines
navigation/
9 lines
tooltip/
22 lines

Diff 43791

View Options

native/components/nux-tips-context.react.js

Loading...
View Options

native/navigation/nux-tip-overlay-backdrop.react.js

Loading...
View Options

native/tooltip/nux-tips-overlay.react.js

Loading...