Page MenuHomePhabricator
Differential D12947

[native] Rename Nux Tips Overlay (and simplify types)
ClosedPublic
Actions

Authored by inka on Jul 30 2024, 7:01 AM.
Tags
None
Referenced Files
F3332710: D12947.id43099.diff
Thu, Nov 21, 1:15 AM
Unknown Object (File)
Sun, Nov 17, 9:35 PM
Unknown Object (File)
Thu, Nov 14, 9:51 AM
Unknown Object (File)
Tue, Nov 12, 5:12 PM
Unknown Object (File)
Tue, Nov 12, 5:07 PM
Unknown Object (File)
Sat, Nov 9, 11:39 PM
Unknown Object (File)
Sat, Nov 9, 10:07 PM
Unknown Object (File)
Wed, Nov 6, 11:33 PM
View All 79 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types)
Summary

issue: ENG-8534

Test Plan

Tested by creating a component with createNuxTipsOverlay and navigating to it. It appears correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Jul 30 2024, 7:01 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 7:01 AM
inka added a parent revision: D12942: [native] Remove irrelevant code from nux tips overlay.Jul 30 2024, 7:01 AM
Harbormaster completed remote builds in B30817: Diff 42970.Jul 30 2024, 7:23 AM
inka requested review of this revision.Jul 30 2024, 7:23 AM
tomek accepted this revision.Jul 31 2024, 6:16 AM
tomek added inline comments.
native/navigation/route-names.js
170 ↗(On Diff #42970)

NUX is an acronym and should be capitalized.

This revision is now accepted and ready to land.Jul 31 2024, 6:16 AM
inka updated this revision to Diff 42994.Jul 31 2024, 6:38 AM

Capitalize

Harbormaster failed remote builds in B30836: Diff 42994!Jul 31 2024, 6:50 AM
inka added a child revision: D12963: [native] Add nux context.Aug 5 2024, 1:38 AM
inka updated this revision to Diff 43099.Aug 5 2024, 5:49 AM
inka marked an inline comment as done.

Fix file import

Harbormaster completed remote builds in B30919: Diff 43099.Aug 5 2024, 7:21 AM
Closed by commit rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types) (authored by inka). · Explain WhyAug 13 2024, 5:43 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types).

Revision Contents
Changeset List

PathSize
native/
navigation/
3 lines
tooltip/
131 lines

Diff 43336

View Options

native/navigation/route-names.js

Loading...
View Options

native/tooltip/nux-tips-overlay.react.js

Loading...