Paths

Table of Contentst

[native] Rename Nux Tips Overlay (and simplify types)
ClosedPublic
Actions

Authored by inka on Jul 30 2024, 7:01 AM.

Details

Reviewers

tomek
will

Commits

rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types)

Summary

issue: ENG-8534

Test Plan

Tested by creating a component with createNuxTipsOverlay and navigating to it. It appears correctly.

Diff Detail

Repository

rCOMM Comm

Branch

inka/nux

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Jul 30 2024, 7:01 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 7:01 AM

inka added a parent revision: D12942: [native] Remove irrelevant code from nux tips overlay.Jul 30 2024, 7:01 AM

Harbormaster completed remote builds in B30817: Diff 42970.Jul 30 2024, 7:23 AM

inka requested review of this revision.Jul 30 2024, 7:23 AM

tomek accepted this revision.Jul 31 2024, 6:16 AM

tomek added inline comments.

native/navigation/route-names.js
170	`NUX` is an acronym and should be capitalized.

This revision is now accepted and ready to land.Jul 31 2024, 6:16 AM

Capitalize

Harbormaster failed remote builds in B30836: Diff 42994!Jul 31 2024, 6:50 AM

inka added a child revision: D12963: [native] Add nux context.Aug 5 2024, 1:38 AM

Fix file import

Harbormaster completed remote builds in B30919: Diff 43099.Aug 5 2024, 7:21 AM

Closed by commit rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types) (authored by inka). · Explain WhyAug 13 2024, 5:43 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types).

Revision Contents
Changeset List

Path

Size

native/

navigation/

route-names.js

3 lines

tooltip/

nux-tips-overlay.react.js

131 lines

Diff 42970

View Options

native/navigation/route-names.js