Page MenuHomePhabricator
Differential D12947

[native] Rename Nux Tips Overlay (and simplify types)
ClosedPublic
Actions

Authored by inka on Jul 30 2024, 7:01 AM.
Tags
None
Referenced Files
F2769491: D12947.diff
Thu, Sep 19, 6:34 PM
Unknown Object (File)
Sat, Sep 7, 1:46 PM
Unknown Object (File)
Thu, Sep 5, 5:15 PM
Unknown Object (File)
Wed, Sep 4, 12:27 AM
Unknown Object (File)
Tue, Sep 3, 5:39 AM
Unknown Object (File)
Mon, Sep 2, 10:20 AM
Unknown Object (File)
Sun, Sep 1, 4:45 AM
Unknown Object (File)
Sun, Sep 1, 4:45 AM
View All 57 Files
Subscribers
ashoat

Details

Reviewers
tomek
will
Commits
rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types)
Summary

issue: ENG-8534

Test Plan

Tested by creating a component with createNuxTipsOverlay and navigating to it. It appears correctly.

Diff Detail

Repository
rCOMM Comm
Branch
inka/nux
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jul 30 2024, 7:01 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 7:01 AM
inka added a parent revision: D12942: [native] Remove irrelevant code from nux tips overlay.Jul 30 2024, 7:01 AM
Harbormaster completed remote builds in B30817: Diff 42970.Jul 30 2024, 7:23 AM
inka requested review of this revision.Jul 30 2024, 7:23 AM
tomek accepted this revision.Jul 31 2024, 6:16 AM
tomek added inline comments.
native/navigation/route-names.js
170 ↗(On Diff #42970)

NUX is an acronym and should be capitalized.

This revision is now accepted and ready to land.Jul 31 2024, 6:16 AM
inka updated this revision to Diff 42994.Jul 31 2024, 6:38 AM

Capitalize

Harbormaster failed remote builds in B30836: Diff 42994!Jul 31 2024, 6:50 AM
inka added a child revision: D12963: [native] Add nux context.Aug 5 2024, 1:38 AM
inka updated this revision to Diff 43099.Aug 5 2024, 5:49 AM
inka marked an inline comment as done.

Fix file import

Harbormaster completed remote builds in B30919: Diff 43099.Aug 5 2024, 7:21 AM
Closed by commit rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types) (authored by inka). · Explain WhyAug 13 2024, 5:43 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMc14514c35977: [native] Rename Nux Tips Overlay (and simplify types).

Revision Contents
Changeset List

PathSize
native/
navigation/
3 lines
tooltip/
131 lines

Diff 42994

View Options

native/navigation/route-names.js

Loading...
View Options

native/tooltip/nux-tips-overlay.react.js

Loading...