Page MenuHomePhabricator

[native] Rename Nux Tips Overlay (and simplify types)
ClosedPublic

Authored by inka on Jul 30 2024, 7:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 11:33 PM
Unknown Object (File)
Sat, Oct 19, 8:23 AM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Oct 6 2024, 8:13 PM
Unknown Object (File)
Oct 1 2024, 3:23 AM
Subscribers

Details

Summary

issue: ENG-8534

Test Plan

Tested by creating a component with createNuxTipsOverlay and navigating to it. It appears correctly.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jul 30 2024, 7:23 AM
tomek added inline comments.
native/navigation/route-names.js
170 ↗(On Diff #42970)

NUX is an acronym and should be capitalized.

This revision is now accepted and ready to land.Jul 31 2024, 6:16 AM
inka marked an inline comment as done.

Fix file import