Page MenuHomePhabricator

[native] Make possible to render tip not pointing to anything
ClosedPublic

Authored by inka on Aug 27 2024, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 11:33 PM
Unknown Object (File)
Sat, Oct 19, 8:23 AM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Fri, Oct 18, 9:47 PM
Unknown Object (File)
Sat, Oct 12, 11:41 PM
Unknown Object (File)
Oct 6 2024, 8:13 PM
Unknown Object (File)
Oct 4 2024, 3:31 AM
Subscribers

Details

Summary

issue: ENG-9062
the intro tip will not be pointing to anything

Test Plan

tested with the next diff:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Aug 27 2024, 10:25 AM
tomek added inline comments.
native/tooltip/nux-tips-overlay.react.js
134–137 ↗(On Diff #43701)

I guess you can have a single invariant for these

This revision is now accepted and ready to land.Aug 28 2024, 4:06 AM

Just some style nits. Please note that we need to handle styling ourselves inside of prettier-ignore

native/tooltip/nux-tips-overlay.react.js
321 ↗(On Diff #43806)

The worklet has to be wrapped with prettier-ignore to avoid stripping the Flow comment annotations, but that means we have to handle the styling ourselves

331 ↗(On Diff #43806)

Whitespace issue here too