[native] Simplify name
ClosedPublic
Actions

Authored by inka on Aug 13 2024, 8:06 AM.

Details

Reviewers

tomek
will

Commits

rCOMMd024104db519: [native] Simplify name

Summary

issue: ENG-8914
The name doesn't have to be this complicated

Test Plan

ted that the component can still be rendered

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 13 2024, 8:06 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 13 2024, 8:06 AM

inka added a parent revision: D13062: [native] Turn MenuComponent into text.Aug 13 2024, 8:06 AM

inka added a child revision: D13064: [native] Modify overlay context to handle reanimated 2 components.Aug 13 2024, 8:23 AM

Harbormaster completed remote builds in B31072: Diff 43358.Aug 13 2024, 8:29 AM

inka requested review of this revision.Aug 13 2024, 8:29 AM

will accepted this revision.Aug 13 2024, 4:18 PM

This revision is now accepted and ready to land.Aug 13 2024, 4:18 PM

tomek accepted this revision.Aug 14 2024, 2:45 AM

tomek added inline comments.

native/tooltip/nux-tips-overlay.react.js
87 ↗	(On Diff #43358)	It looks like we need to rebase this diff.

Rebase

Harbormaster completed remote builds in B31134: Diff 43447.Aug 19 2024, 5:16 AM

Closed by commit rCOMMd024104db519: [native] Simplify name (authored by inka). · Explain WhyAug 20 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMd024104db519: [native] Simplify name.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

4 lines

Diff 43447

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Simplify nameClosedPublicActions