[native] Simplify types
ClosedPublic
Actions

Authored by inka on Aug 13 2024, 8:26 AM.

Details

Reviewers

tomek
will

Commits

rCOMM5c1b9d97b69a: [native] Simplify types

Summary

issue: ENG-9814
I don't need to pass progress to the button components. This is needed for example in text message so that it can move to the right space after being pressed (in oreder to display tooltip). The nux tips don't need this

Test Plan

N/A - this code isn't being used anywhere yet, and the change is very simple

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Aug 13 2024, 8:26 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 13 2024, 8:26 AM

inka edited the test plan for this revision. (Show Details)Aug 13 2024, 8:26 AM

inka added a parent revision: D13064: [native] Modify overlay context to handle reanimated 2 components.

inka added a child revision: D13066: [native] Refactor background opacity to reanimated 2.Aug 13 2024, 8:37 AM

Harbormaster completed remote builds in B31074: Diff 43360.Aug 13 2024, 8:44 AM

inka requested review of this revision.Aug 13 2024, 8:44 AM

will accepted this revision.Aug 13 2024, 4:20 PM

This revision is now accepted and ready to land.Aug 13 2024, 4:20 PM

Rebase

Harbormaster completed remote builds in B31088: Diff 43374.Aug 14 2024, 1:43 AM

tomek accepted this revision.Aug 14 2024, 5:36 AM

Closed by commit rCOMM5c1b9d97b69a: [native] Simplify types (authored by inka). · Explain WhyAug 20 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM5c1b9d97b69a: [native] Simplify types.

Revision Contents
Changeset List

Path

Size

native/

tooltip/

nux-tips-overlay.react.js

22 lines

Diff 43374

View Options

native/tooltip/nux-tips-overlay.react.js

[native] Simplify typesClosedPublicActions