Paths

Table of Contentst

Differential D13146

[lib] update `useProcessDMOperation` to use `DMOperationSpecification`
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 4:54 AM.

Tags

None

Referenced Files

	F3193600: D13146.id43632.diff
	Fri, Nov 8, 11:06 PM

	Unknown Object (File)
	Fri, Nov 8, 3:21 PM

	Unknown Object (File)
	Fri, Nov 8, 9:45 AM

	Unknown Object (File)
	Fri, Nov 8, 2:29 AM

	Unknown Object (File)
	Fri, Oct 25, 2:37 AM

	Unknown Object (File)
	Sat, Oct 19, 2:33 PM

	Unknown Object (File)
	Sat, Oct 19, 2:33 PM

	Unknown Object (File)
	Sat, Oct 19, 2:32 PM

View All 38 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM6e9bf6ed9d9f: [lib] update `useProcessDMOperation` to use `DMOperationSpecification`

Summary

In this hook, we need to generate OutboundP2PMessages to save this in DB in the same SQL transaction to handle cases when the app crashes after applying changes to our store and before addressing messages to other peers - this is inconsistency from which we're unable to heal.

Depends on D13145

Test Plan

Flow

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 23 2024, 4:54 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 4:54 AM

kamil added a child revision: D13148: [lib] update `processDMOpsActionType` to handle `outboundP2PMessages`.Aug 23 2024, 5:05 AM

Harbormaster completed remote builds in B31230: Diff 43603.Aug 23 2024, 5:11 AM

kamil published this revision for review.Aug 23 2024, 7:24 AM

tomek accepted this revision.Aug 26 2024, 1:49 AM

tomek added inline comments.

lib/shared/dm-ops/dm-ops-queue-handler.react.js
64 ↗	(On Diff #43603)	It might be a good idea to explain in a code comment why it is guaranteed to be an inbound.

This revision is now accepted and ready to land.Aug 26 2024, 1:49 AM

add comment

Harbormaster completed remote builds in B31257: Diff 43632.Aug 26 2024, 6:20 AM

Closed by commit rCOMM6e9bf6ed9d9f: [lib] update `useProcessDMOperation` to use `DMOperationSpecification` (authored by kamil). · Explain WhyAug 26 2024, 9:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6e9bf6ed9d9f: [lib] update `useProcessDMOperation` to use `DMOperationSpecification`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

dm-ops-queue-handler.react.js

12 lines

process-dm-ops.js

16 lines

tunnelbroker/

use-peer-to-peer-message-handler.js

11 lines

Diff 43646

lib/shared/dm-ops/dm-ops-queue-handler.react.js

Loading...

lib/shared/dm-ops/process-dm-ops.js

Loading...

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...