Paths

Table of Contentst

Differential D13155

[lib] implement action for sending DM messages
ClosedPublic
Actions

Authored by kamil on Fri, Aug 23, 5:42 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 13, 12:08 PM

	Unknown Object (File)
	Fri, Sep 13, 7:37 AM

	Unknown Object (File)
	Mon, Sep 9, 10:26 AM

	Unknown Object (File)
	Mon, Sep 9, 10:06 AM

	Unknown Object (File)
	Thu, Sep 5, 2:11 PM

	Unknown Object (File)
	Wed, Sep 4, 6:22 PM

	Unknown Object (File)
	Tue, Sep 3, 6:26 PM

	Unknown Object (File)
	Mon, Sep 2, 6:21 AM

View All 28 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM3ab02a144ee6: [lib] implement action for sending DM messages

Summary

Action dispatched when processing DM Operation, sucess will be dispatched when Tunnelbroker finished queueing messages.

SEND_DM_FAILED is not needed but implemented it this way to use dispatchActionPromise.

Depends on D13154

Test Plan

Test dispatching this action.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Aug 23, 5:42 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFri, Aug 23, 5:42 AM

kamil added inline comments.Fri, Aug 23, 5:44 AM

lib/reducers/message-reducer.js
1878 ↗	(On Diff #43612)	I think we should remove the local entry when `remainingOutboundP2PMessageIDs.length === 0`.

kamil added a child revision: D13156: [lib] implement sending DM messages with tracking of success/failures.Fri, Aug 23, 5:47 AM

Harbormaster completed remote builds in B31239: Diff 43612.Fri, Aug 23, 5:59 AM

kamil published this revision for review.Fri, Aug 23, 7:26 AM

kamil added inline comments.

lib/reducers/message-reducer.js
1893 ↗	(On Diff #43612)	this is used to show message in progress in UI when retrying

tomek accepted this revision.Mon, Aug 26, 4:17 AM

tomek added inline comments.

lib/reducers/message-reducer.js
1865 ↗	(On Diff #43612)	We should create a `Set` from it before filtering.
1878 ↗	(On Diff #43612)	Agree
lib/types/redux-types.js
1596 ↗	(On Diff #43612)	Do you think it makes sense to rename this type?

This revision is now accepted and ready to land.Mon, Aug 26, 4:17 AM

rename type
use Set
remove local entry after success

Harbormaster completed remote builds in B31265: Diff 43640.Mon, Aug 26, 7:40 AM

Closed by commit rCOMM3ab02a144ee6: [lib] implement action for sending DM messages (authored by kamil). · Explain WhyMon, Aug 26, 9:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3ab02a144ee6: [lib] implement action for sending DM messages.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

59 lines

types/

15 lines

18 lines

Diff 43655

lib/reducers/message-reducer.js

Loading...

lib/types/dm-ops.js

Loading...

lib/types/redux-types.js

Loading...