Page MenuHomePhabricator

[lib] implement sending DM text messages
ClosedPublic

Authored by kamil on Aug 23 2024, 7:01 AM.
Tags
None
Referenced Files
F3193608: D13160.id43643.diff
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 2:09 AM
Unknown Object (File)
Fri, Nov 8, 2:09 AM
Unknown Object (File)
Fri, Nov 8, 1:42 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Fri, Oct 18, 8:57 PM
Unknown Object (File)
Fri, Oct 18, 7:20 PM
Unknown Object (File)
Fri, Oct 18, 5:59 PM
Subscribers

Details

Summary

ENG-8423.

Depends on D13159

Test Plan

Test sending text message

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 23 2024, 7:28 AM
kamil added inline comments.
native/input/input-state-container.react.js
486 ↗(On Diff #43617)

wondering, if we should use something like this here

tomek added inline comments.
native/input/input-state-container.react.js
486 ↗(On Diff #43617)

It is an interesting idea, but we would need to make sure that the local IDs are UUIDs. But even then, I'm not sure if it would really be beneficial. On the other hand, it is a bit confusing why the messageInfo has an ID that isn't used here.

491–492 ↗(On Diff #43617)

Shouldn't we send this message to all the users? We should inform other devices of the viewer about this operation.

This revision is now accepted and ready to land.Aug 26 2024, 4:38 AM

send message to other sender devices

native/input/input-state-container.react.js
486 ↗(On Diff #43617)

I'll leave it as it is to not interfere with how our UUIDs work

491–492 ↗(On Diff #43617)

not to all users, but we should not remove the sender from recipientIDs

This revision was automatically updated to reflect the committed changes.