Page MenuHomePhabricator
Differential D13151

[lib] deprecate `sendDMOperation` and implement method to create sending promise
ClosedPublic
Actions

Authored by kamil on Fri, Aug 23, 5:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 2:54 PM
Unknown Object (File)
Wed, Sep 11, 11:09 PM
Unknown Object (File)
Wed, Sep 11, 6:43 PM
Unknown Object (File)
Mon, Sep 9, 8:03 PM
Unknown Object (File)
Sun, Sep 8, 4:16 PM
Unknown Object (File)
Fri, Sep 6, 11:30 AM
Unknown Object (File)
Fri, Sep 6, 11:07 AM
Unknown Object (File)
Thu, Sep 5, 2:51 AM
View All 30 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM1bd677c10966: [lib] deprecate `sendDMOperation` and implement method to create sending promise
Summary

ENG-8423.

We still need promise to be resolved after sending messages, but generating messages was moved to processDMOps.

Returning promise to later in that stack put it to dispatchActionPromise.

useProcessAndSendDMOperation looks no obsolete, but will be updated later in the stack.

Depends on D13150

Test Plan

Call getDMOpsSendingPromise and check if it works.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Aug 23, 5:19 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Aug 23, 5:19 AM
kamil added a child revision: D13152: [lib] introduce `DispatchMetadata` for Inbound and Outbound actions.Fri, Aug 23, 5:24 AM
Harbormaster completed remote builds in B31235: Diff 43608.Fri, Aug 23, 5:35 AM
kamil published this revision for review.Fri, Aug 23, 7:25 AM
tomek accepted this revision.Mon, Aug 26, 3:30 AM
tomek added inline comments.
lib/shared/dm-ops/process-dm-ops.js
187–197 ↗(On Diff #43608)

At this point, it is equivalent to

const useProcessAndSendDMOperation = useProcessDMOperation;

But it doesn't matter because it is updated later in the stack.

This revision is now accepted and ready to land.Mon, Aug 26, 3:30 AM
kamil updated this revision to Diff 43634.Mon, Aug 26, 6:31 AM

rebase

Harbormaster failed remote builds in B31259: Diff 43634!Mon, Aug 26, 6:45 AM
Harbormaster completed remote builds in B31259: Diff 43634.Mon, Aug 26, 7:01 AM
Closed by commit rCOMM1bd677c10966: [lib] deprecate `sendDMOperation` and implement method to create sending promise (authored by kamil). · Explain WhyMon, Aug 26, 9:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM1bd677c10966: [lib] deprecate `sendDMOperation` and implement method to create sending promise.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
5 lines
tunnelbroker/
57 lines

Diff 43650

View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...