Page MenuHomePhabricator
Differential D13158

[lib][web][native] implement detecting DM messages as failed
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Sun, Mar 9, 9:10 PM
Unknown Object (File)
Thu, Feb 27, 3:11 AM
Unknown Object (File)
Feb 18 2025, 12:19 AM
Unknown Object (File)
Feb 16 2025, 4:58 PM
Unknown Object (File)
Jan 15 2025, 7:21 AM
View All 52 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM9bf68e8cf983: [lib][web][native] implement detecting DM messages as failed
Summary

ENG-8423.

Further simplification is complicated because of different types on different platforms.

Depends on D13157

Test Plan

Message visible in UI as failed.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
32 lines
native/
chat/
14 lines
web/
chat/
20 lines

Diff 43659

View Options

lib/shared/chat-utils.js

  • This file was added.
// @flow
import * as React from 'react';
import { messageTypes } from '../types/message-types-enum.js';
import type { RawMessageInfo } from '../types/message-types.js';
import { getConfig } from '../utils/config.js';
import { translateClientDBMessageInfoToRawMessageInfo } from '../utils/message-ops-utils.js';
function useGetLatestMessageEdit(): (
messageID: string,
) => Promise<?RawMessageInfo> {
const { getRelatedMessages } = getConfig().sqliteAPI;
return React.useCallback(
async (messageID: string) => {
const relatedDBMessages = await getRelatedMessages(messageID);
const relatedMessages = relatedDBMessages.map(
translateClientDBMessageInfoToRawMessageInfo,
);
// First, get the original message, which should be the last
// since the results are sorted on time
const originalMessage = relatedMessages.pop();
if (!originalMessage) {
return undefined;
}
if (originalMessage.id !== messageID) {
console.log('last related message is not original message');
return undefined;
}
// Edits are only supported for text messages
if (originalMessage.type !== messageTypes.TEXT) {
return originalMessage;
}
// Next, get the latest edit, if there is one
let editedOriginalMessage = originalMessage;
for (const relatedMessage of relatedMessages) {
if (relatedMessage.type !== messageTypes.EDIT_MESSAGE) {
continue;
}
editedOriginalMessage = {
...originalMessage,
text: relatedMessage.text,
};
break;
}
return editedOriginalMessage;
},
[getRelatedMessages],
);
}
export { useGetLatestMessageEdit };
View Options

native/chat/text-message-send-failed.js

  • This file was added.
// @flow
import * as React from 'react';
import { messageTypes } from '../types/message-types-enum.js';
import type { RawMessageInfo } from '../types/message-types.js';
import { getConfig } from '../utils/config.js';
import { translateClientDBMessageInfoToRawMessageInfo } from '../utils/message-ops-utils.js';
function useGetLatestMessageEdit(): (
messageID: string,
) => Promise<?RawMessageInfo> {
const { getRelatedMessages } = getConfig().sqliteAPI;
return React.useCallback(
async (messageID: string) => {
const relatedDBMessages = await getRelatedMessages(messageID);
const relatedMessages = relatedDBMessages.map(
translateClientDBMessageInfoToRawMessageInfo,
);
// First, get the original message, which should be the last
// since the results are sorted on time
const originalMessage = relatedMessages.pop();
if (!originalMessage) {
return undefined;
}
if (originalMessage.id !== messageID) {
console.log('last related message is not original message');
return undefined;
}
// Edits are only supported for text messages
if (originalMessage.type !== messageTypes.TEXT) {
return originalMessage;
}
// Next, get the latest edit, if there is one
let editedOriginalMessage = originalMessage;
for (const relatedMessage of relatedMessages) {
if (relatedMessage.type !== messageTypes.EDIT_MESSAGE) {
continue;
}
editedOriginalMessage = {
...originalMessage,
text: relatedMessage.text,
};
break;
}
return editedOriginalMessage;
},
[getRelatedMessages],
);
}
export { useGetLatestMessageEdit };
View Options

web/chat/text-message-send-failed.js

  • This file was added.
// @flow
import * as React from 'react';
import { messageTypes } from '../types/message-types-enum.js';
import type { RawMessageInfo } from '../types/message-types.js';
import { getConfig } from '../utils/config.js';
import { translateClientDBMessageInfoToRawMessageInfo } from '../utils/message-ops-utils.js';
function useGetLatestMessageEdit(): (
messageID: string,
) => Promise<?RawMessageInfo> {
const { getRelatedMessages } = getConfig().sqliteAPI;
return React.useCallback(
async (messageID: string) => {
const relatedDBMessages = await getRelatedMessages(messageID);
const relatedMessages = relatedDBMessages.map(
translateClientDBMessageInfoToRawMessageInfo,
);
// First, get the original message, which should be the last
// since the results are sorted on time
const originalMessage = relatedMessages.pop();
if (!originalMessage) {
return undefined;
}
if (originalMessage.id !== messageID) {
console.log('last related message is not original message');
return undefined;
}
// Edits are only supported for text messages
if (originalMessage.type !== messageTypes.TEXT) {
return originalMessage;
}
// Next, get the latest edit, if there is one
let editedOriginalMessage = originalMessage;
for (const relatedMessage of relatedMessages) {
if (relatedMessage.type !== messageTypes.EDIT_MESSAGE) {
continue;
}
editedOriginalMessage = {
...originalMessage,
text: relatedMessage.text,
};
break;
}
return editedOriginalMessage;
},
[getRelatedMessages],
);
}
export { useGetLatestMessageEdit };