Page MenuHomePhabricator
Differential D13152

[lib] introduce `DispatchMetadata` for Inbound and Outbound actions
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:24 AM.
Tags
None
Referenced Files
F6097353: D13152.id43610.diff
Mon, Apr 21, 5:13 AM
Unknown Object (File)
Sat, Apr 19, 5:00 AM
Unknown Object (File)
Fri, Apr 18, 2:02 AM
Unknown Object (File)
Thu, Apr 17, 6:56 PM
Unknown Object (File)
Thu, Apr 17, 11:12 AM
Unknown Object (File)
Sat, Apr 12, 5:41 AM
Unknown Object (File)
Tue, Apr 1, 8:46 AM
Unknown Object (File)
Mar 5 2025, 4:53 PM
View All 56 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM1cf8179f3cc9: [lib] introduce `DispatchMetadata` for Inbound and Outbound actions
Summary

ENG-8423.

This improves types and naming to reflect rest of the codebase.

SCHEDULE_P2P_MESSAGES is no longer needed, P2P messages are now part of PROCESS_DM_OPS.

Depends on D13151

Test Plan

Flow

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
handlers/
11 lines
hooks/
15 lines
reducers/
29 lines
6 lines
shared/
dm-ops/
4 lines
10 lines
types/
9 lines
6 lines
20 lines
4 lines
native/
redux/
5 lines
2 lines
web/
redux/
11 lines

Diff 43652

View Options

lib/handlers/db-ops-handler.react.js

Show First 20 Lines • Show All 346 Lines • ▼ Show 20 Lines
}; };
export const processDMOpsActionType = 'PROCESS_DM_OPS'; export const processDMOpsActionType = 'PROCESS_DM_OPS';
export type ProcessDMOpsPayload = { export type ProcessDMOpsPayload = {
+rawMessageInfos: $ReadOnlyArray<RawMessageInfo>, +rawMessageInfos: $ReadOnlyArray<RawMessageInfo>,
+updateInfos: $ReadOnlyArray<ClientUpdateInfo>, +updateInfos: $ReadOnlyArray<ClientUpdateInfo>,
+outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>, +outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>,
// For messages that could be retried from UI, we need to bind DM `messageID`
// with `outboundP2PMessages` to keep track of whether all P2P messages
// were queued on Tunnelbroker.
+messageIDWithoutAutoRetry: ?string,
}; };
export const queueDMOpsActionType = 'QUEUE_DM_OPS'; export const queueDMOpsActionType = 'QUEUE_DM_OPS';
export type QueueDMOpsPayload = { export type QueueDMOpsPayload = {
+operation: DMOperation, +operation: DMOperation,
+threadID: string, +threadID: string,
+timestamp: number, +timestamp: number,
}; };
Show All 19 Lines
View Options

lib/hooks/ops-hooks.js

Show First 20 Lines • Show All 346 Lines • ▼ Show 20 Lines
}; };
export const processDMOpsActionType = 'PROCESS_DM_OPS'; export const processDMOpsActionType = 'PROCESS_DM_OPS';
export type ProcessDMOpsPayload = { export type ProcessDMOpsPayload = {
+rawMessageInfos: $ReadOnlyArray<RawMessageInfo>, +rawMessageInfos: $ReadOnlyArray<RawMessageInfo>,
+updateInfos: $ReadOnlyArray<ClientUpdateInfo>, +updateInfos: $ReadOnlyArray<ClientUpdateInfo>,
+outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>, +outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>,
// For messages that could be retried from UI, we need to bind DM `messageID`
// with `outboundP2PMessages` to keep track of whether all P2P messages
// were queued on Tunnelbroker.
+messageIDWithoutAutoRetry: ?string,
}; };
export const queueDMOpsActionType = 'QUEUE_DM_OPS'; export const queueDMOpsActionType = 'QUEUE_DM_OPS';
export type QueueDMOpsPayload = { export type QueueDMOpsPayload = {
+operation: DMOperation, +operation: DMOperation,
+threadID: string, +threadID: string,
+timestamp: number, +timestamp: number,
}; };
Show All 19 Lines
View Options

lib/reducers/db-ops-reducer.js

Show First 20 Lines • Show All 346 Lines • ▼ Show 20 Lines
}; };
export const processDMOpsActionType = 'PROCESS_DM_OPS'; export const processDMOpsActionType = 'PROCESS_DM_OPS';
export type ProcessDMOpsPayload = { export type ProcessDMOpsPayload = {
+rawMessageInfos: $ReadOnlyArray<RawMessageInfo>, +rawMessageInfos: $ReadOnlyArray<RawMessageInfo>,
+updateInfos: $ReadOnlyArray<ClientUpdateInfo>, +updateInfos: $ReadOnlyArray<ClientUpdateInfo>,
+outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>, +outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>,
// For messages that could be retried from UI, we need to bind DM `messageID`
// with `outboundP2PMessages` to keep track of whether all P2P messages
// were queued on Tunnelbroker.
+messageIDWithoutAutoRetry: ?string,
}; };
export const queueDMOpsActionType = 'QUEUE_DM_OPS'; export const queueDMOpsActionType = 'QUEUE_DM_OPS';
export type QueueDMOpsPayload = { export type QueueDMOpsPayload = {
+operation: DMOperation, +operation: DMOperation,
+threadID: string, +threadID: string,
+timestamp: number, +timestamp: number,
}; };
Show All 19 Lines
View Options

lib/reducers/db-ops-reducer.test.js

Show First 20 Lines • Show All 346 Lines • ▼ Show 20 Lines
}; };
export const processDMOpsActionType = 'PROCESS_DM_OPS'; export const processDMOpsActionType = 'PROCESS_DM_OPS';
export type ProcessDMOpsPayload = { export type ProcessDMOpsPayload = {
+rawMessageInfos: $ReadOnlyArray<RawMessageInfo>, +rawMessageInfos: $ReadOnlyArray<RawMessageInfo>,
+updateInfos: $ReadOnlyArray<ClientUpdateInfo>, +updateInfos: $ReadOnlyArray<ClientUpdateInfo>,
+outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>, +outboundP2PMessages: ?$ReadOnlyArray<OutboundP2PMessage>,
// For messages that could be retried from UI, we need to bind DM `messageID`
// with `outboundP2PMessages` to keep track of whether all P2P messages
// were queued on Tunnelbroker.
+messageIDWithoutAutoRetry: ?string,
}; };
export const queueDMOpsActionType = 'QUEUE_DM_OPS'; export const queueDMOpsActionType = 'QUEUE_DM_OPS';
export type QueueDMOpsPayload = { export type QueueDMOpsPayload = {
+operation: DMOperation, +operation: DMOperation,
+threadID: string, +threadID: string,
+timestamp: number, +timestamp: number,
}; };
Show All 19 Lines
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/types/db-ops-types.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/request-types.js

Loading...
View Options

native/redux/action-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

web/redux/redux-setup.js

Loading...