Page MenuHomePhabricator
Differential D13152

[lib] introduce `DispatchMetadata` for Inbound and Outbound actions
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 5, 4:53 PM
Unknown Object (File)
Wed, Mar 5, 9:22 AM
Unknown Object (File)
Wed, Mar 5, 9:22 AM
Unknown Object (File)
Wed, Mar 5, 9:21 AM
Unknown Object (File)
Wed, Mar 5, 9:21 AM
Unknown Object (File)
Thu, Feb 27, 5:40 AM
Unknown Object (File)
Feb 12 2025, 12:48 AM
Unknown Object (File)
Jan 15 2025, 8:14 AM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMM1cf8179f3cc9: [lib] introduce `DispatchMetadata` for Inbound and Outbound actions
Summary

ENG-8423.

This improves types and naming to reflect rest of the codebase.

SCHEDULE_P2P_MESSAGES is no longer needed, P2P messages are now part of PROCESS_DM_OPS.

Depends on D13151

Test Plan

Flow

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
handlers/
11 lines
hooks/
15 lines
reducers/
29 lines
6 lines
shared/
dm-ops/
4 lines
10 lines
types/
9 lines
6 lines
20 lines
4 lines
native/
redux/
5 lines
2 lines
web/
redux/
11 lines

Diff 43652

View Options

lib/handlers/db-ops-handler.react.js

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { import type {
UpdateConnectionStatusPayload, UpdateConnectionStatusPayload,
SetLateResponsePayload, SetLateResponsePayload,
UpdateKeyserverReachabilityPayload, UpdateKeyserverReachabilityPayload,
} from '../keyserver-conn/keyserver-conn-types.js'; } from '../keyserver-conn/keyserver-conn-types.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { AlertInfo } from '../types/alert-types.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
+threadStore: ThreadStore, +threadStore: ThreadStore,
+userStore: UserStore, +userStore: UserStore,
+messageStore: MessageStore, +messageStore: MessageStore,
+loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } }, +loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } },
+calendarFilters: $ReadOnlyArray<CalendarFilter>, +calendarFilters: $ReadOnlyArray<CalendarFilter>,
+notifPermissionAlertInfo: NotifPermissionAlertInfo, +notifPermissionAlertInfo: AlertInfo,
+watchedThreadIDs: $ReadOnlyArray<string>, +watchedThreadIDs: $ReadOnlyArray<string>,
+lifecycleState: LifecycleState, +lifecycleState: LifecycleState,
+enabledApps: EnabledApps, +enabledApps: EnabledApps,
+reportStore: ReportStore, +reportStore: ReportStore,
+dataLoaded: boolean, +dataLoaded: boolean,
+userPolicies: UserPolicies, +userPolicies: UserPolicies,
+commServicesAccessToken: ?string, +commServicesAccessToken: ?string,
+inviteLinksStore: InviteLinksStore, +inviteLinksStore: InviteLinksStore,
▲ Show 20 Lines • Show All 1,255 Lines • Show Last 20 Lines
View Options

lib/hooks/ops-hooks.js

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { import type {
UpdateConnectionStatusPayload, UpdateConnectionStatusPayload,
SetLateResponsePayload, SetLateResponsePayload,
UpdateKeyserverReachabilityPayload, UpdateKeyserverReachabilityPayload,
} from '../keyserver-conn/keyserver-conn-types.js'; } from '../keyserver-conn/keyserver-conn-types.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { AlertInfo } from '../types/alert-types.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
+threadStore: ThreadStore, +threadStore: ThreadStore,
+userStore: UserStore, +userStore: UserStore,
+messageStore: MessageStore, +messageStore: MessageStore,
+loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } }, +loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } },
+calendarFilters: $ReadOnlyArray<CalendarFilter>, +calendarFilters: $ReadOnlyArray<CalendarFilter>,
+notifPermissionAlertInfo: NotifPermissionAlertInfo, +notifPermissionAlertInfo: AlertInfo,
+watchedThreadIDs: $ReadOnlyArray<string>, +watchedThreadIDs: $ReadOnlyArray<string>,
+lifecycleState: LifecycleState, +lifecycleState: LifecycleState,
+enabledApps: EnabledApps, +enabledApps: EnabledApps,
+reportStore: ReportStore, +reportStore: ReportStore,
+dataLoaded: boolean, +dataLoaded: boolean,
+userPolicies: UserPolicies, +userPolicies: UserPolicies,
+commServicesAccessToken: ?string, +commServicesAccessToken: ?string,
+inviteLinksStore: InviteLinksStore, +inviteLinksStore: InviteLinksStore,
▲ Show 20 Lines • Show All 1,255 Lines • Show Last 20 Lines
View Options

lib/reducers/db-ops-reducer.js

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { import type {
UpdateConnectionStatusPayload, UpdateConnectionStatusPayload,
SetLateResponsePayload, SetLateResponsePayload,
UpdateKeyserverReachabilityPayload, UpdateKeyserverReachabilityPayload,
} from '../keyserver-conn/keyserver-conn-types.js'; } from '../keyserver-conn/keyserver-conn-types.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { AlertInfo } from '../types/alert-types.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
+threadStore: ThreadStore, +threadStore: ThreadStore,
+userStore: UserStore, +userStore: UserStore,
+messageStore: MessageStore, +messageStore: MessageStore,
+loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } }, +loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } },
+calendarFilters: $ReadOnlyArray<CalendarFilter>, +calendarFilters: $ReadOnlyArray<CalendarFilter>,
+notifPermissionAlertInfo: NotifPermissionAlertInfo, +notifPermissionAlertInfo: AlertInfo,
+watchedThreadIDs: $ReadOnlyArray<string>, +watchedThreadIDs: $ReadOnlyArray<string>,
+lifecycleState: LifecycleState, +lifecycleState: LifecycleState,
+enabledApps: EnabledApps, +enabledApps: EnabledApps,
+reportStore: ReportStore, +reportStore: ReportStore,
+dataLoaded: boolean, +dataLoaded: boolean,
+userPolicies: UserPolicies, +userPolicies: UserPolicies,
+commServicesAccessToken: ?string, +commServicesAccessToken: ?string,
+inviteLinksStore: InviteLinksStore, +inviteLinksStore: InviteLinksStore,
▲ Show 20 Lines • Show All 1,255 Lines • Show Last 20 Lines
View Options

lib/reducers/db-ops-reducer.test.js

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines
import type { ClientUpdatesResultWithUserInfos } from './update-types.js'; import type { ClientUpdatesResultWithUserInfos } from './update-types.js';
import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js'; import type { CurrentUserInfo, UserInfos, UserStore } from './user-types.js';
import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js'; import type { SetDeviceTokenActionPayload } from '../actions/device-actions.js';
import type { import type {
UpdateConnectionStatusPayload, UpdateConnectionStatusPayload,
SetLateResponsePayload, SetLateResponsePayload,
UpdateKeyserverReachabilityPayload, UpdateKeyserverReachabilityPayload,
} from '../keyserver-conn/keyserver-conn-types.js'; } from '../keyserver-conn/keyserver-conn-types.js';
import type { NotifPermissionAlertInfo } from '../utils/push-alerts.js'; import type { AlertInfo } from '../types/alert-types.js';
export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = { export type BaseAppState<NavInfo: BaseNavInfo = BaseNavInfo> = {
+navInfo: NavInfo, +navInfo: NavInfo,
+currentUserInfo: ?CurrentUserInfo, +currentUserInfo: ?CurrentUserInfo,
+draftStore: DraftStore, +draftStore: DraftStore,
+entryStore: EntryStore, +entryStore: EntryStore,
+threadStore: ThreadStore, +threadStore: ThreadStore,
+userStore: UserStore, +userStore: UserStore,
+messageStore: MessageStore, +messageStore: MessageStore,
+loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } }, +loadingStatuses: { [key: string]: { [idx: number]: LoadingStatus } },
+calendarFilters: $ReadOnlyArray<CalendarFilter>, +calendarFilters: $ReadOnlyArray<CalendarFilter>,
+notifPermissionAlertInfo: NotifPermissionAlertInfo, +notifPermissionAlertInfo: AlertInfo,
+watchedThreadIDs: $ReadOnlyArray<string>, +watchedThreadIDs: $ReadOnlyArray<string>,
+lifecycleState: LifecycleState, +lifecycleState: LifecycleState,
+enabledApps: EnabledApps, +enabledApps: EnabledApps,
+reportStore: ReportStore, +reportStore: ReportStore,
+dataLoaded: boolean, +dataLoaded: boolean,
+userPolicies: UserPolicies, +userPolicies: UserPolicies,
+commServicesAccessToken: ?string, +commServicesAccessToken: ?string,
+inviteLinksStore: InviteLinksStore, +inviteLinksStore: InviteLinksStore,
▲ Show 20 Lines • Show All 1,255 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/dm-op-utils.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/types/db-ops-types.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/request-types.js

Loading...
View Options

native/redux/action-types.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

web/redux/redux-setup.js

Loading...