Paths

Table of Contentst

Differential D13157

[lib] add passing DM operation ID when dispatching action
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:49 AM.

Tags

None

Referenced Files

	F3193607: D13157.id43642.diff
	Fri, Nov 8, 11:06 PM

	Unknown Object (File)
	Fri, Nov 8, 2:29 AM

	Unknown Object (File)
	Fri, Oct 25, 2:37 AM

	Unknown Object (File)
	Sat, Oct 19, 2:33 PM

	Unknown Object (File)
	Sat, Oct 19, 2:33 PM

	Unknown Object (File)
	Sat, Oct 19, 2:32 PM

	Unknown Object (File)
	Fri, Oct 18, 8:57 PM

	Unknown Object (File)
	Fri, Oct 18, 5:57 PM

View All 36 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM1e1af8136d22: [lib] add passing DM operation ID when dispatching action

Summary

dmOpID is needed to resolve promise returned from getDMOpsSendingPromise after queueing messages on Tunnelbroker.

Depends on D13156

Test Plan

Test that promise is resolved/rejected.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 23 2024, 5:49 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 5:49 AM

kamil added a child revision: D13158: [lib][web][native] implement detecting DM messages as failed.Aug 23 2024, 5:52 AM

Harbormaster completed remote builds in B31241: Diff 43614.Aug 23 2024, 6:08 AM

kamil published this revision for review.Aug 23 2024, 7:27 AM

tomek accepted this revision.Aug 26 2024, 5:13 AM

tomek added inline comments.

lib/shared/dm-ops/process-dm-ops.js
82–91 ↗	(On Diff #43614)	It will be less confusing when expressed as an `if-else` because now it looks like `metadata` could be present for `OUTBOUND` messages.

This revision is now accepted and ready to land.Aug 26 2024, 5:13 AM

address review

Harbormaster completed remote builds in B31267: Diff 43642.Aug 26 2024, 7:46 AM

Closed by commit rCOMM1e1af8136d22: [lib] add passing DM operation ID when dispatching action (authored by kamil). · Explain WhyAug 26 2024, 9:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1e1af8136d22: [lib] add passing DM operation ID when dispatching action.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

process-dm-ops.js

32 lines

Diff 43657

lib/shared/dm-ops/process-dm-ops.js

Loading...