Page MenuHomePhabricator
Differential D13161

[lib] implement retrying DM text messages
ClosedPublic
Actions

Authored by kamil on Fri, Aug 23, 7:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 11:09 PM
Unknown Object (File)
Thu, Sep 12, 10:32 AM
Unknown Object (File)
Thu, Sep 12, 10:10 AM
Unknown Object (File)
Mon, Sep 9, 9:46 AM
Unknown Object (File)
Fri, Sep 6, 6:27 PM
Unknown Object (File)
Wed, Sep 4, 9:10 PM
Unknown Object (File)
Wed, Sep 4, 4:42 PM
Unknown Object (File)
Wed, Sep 4, 2:46 PM
View All 34 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMa242a4493a2f: [lib] implement retrying DM text messages
Summary

ENG-8423.

Am alternative is to implement this in InputStateContainer, but will require a lot more changes and I don't think it's better.

Depends on D13160

Test Plan

Test retrying message

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Aug 23, 7:18 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Aug 23, 7:18 AM
kamil published this revision for review.Fri, Aug 23, 7:28 AM
kamil added inline comments.
lib/shared/dm-ops/process-dm-ops.js
274 ↗(On Diff #43618)
Harbormaster completed remote builds in B31245: Diff 43618.Fri, Aug 23, 7:35 AM
tomek accepted this revision.Mon, Aug 26, 4:42 AM
tomek added inline comments.
native/chat/failed-send.react.js
155 ↗(On Diff #43618)

Should we add some protection about multiple retries of the same messages being run simultaneously?

This revision is now accepted and ready to land.Mon, Aug 26, 4:42 AM
kamil added inline comments.Mon, Aug 26, 7:47 AM
native/chat/failed-send.react.js
155 ↗(On Diff #43618)

I think this is implemented here using retryingText

kamil updated this revision to Diff 43644.Mon, Aug 26, 8:22 AM

update

Harbormaster failed remote builds in B31269: Diff 43644!Mon, Aug 26, 8:49 AM
This revision was landed with ongoing or failed builds.Mon, Aug 26, 9:05 AM
Closed by commit rCOMMa242a4493a2f: [lib] implement retrying DM text messages (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa242a4493a2f: [lib] implement retrying DM text messages.
Harbormaster completed remote builds in B31269: Diff 43644.Mon, Aug 26, 9:06 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
35 lines
native/
chat/
28 lines
web/
chat/
21 lines

Diff 43661

View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

native/chat/failed-send.react.js

Loading...
View Options

web/chat/failed-send.react.js

Loading...