Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/shared/dm-ops/process-dm-ops.js | ||
---|---|---|
212–213 ↗ | (On Diff #43613) | At this point, it doesn't work, because these aren't related in any way, but it is fixed in the next diff. |
Comment Actions
A little confused reading this code, as it's unclear to me how supportsAutoRetry specs get sent
Included a couple nits since I'm already asking for a follow-up diff
lib/shared/dm-ops/process-dm-ops.js | ||
---|---|---|
216 | Wondering why we have this !supportsAutoRetry condition here. Is the idea that !supportsAutoRetry need to be manually sent when processAndSendDMOperation is called, whereas supportsAutoRetry gets automatically sent by some other mechanism? If so, it would be good to add a code comment explaining this, and pointing to the other mechanism. | |
218 | Nit: invert condition to reduce indentation | |
219 | Nit |