Page MenuHomePhabricator

[lib] implement sending DM messages with tracking of success/failures
ClosedPublic

Authored by kamil on Aug 23 2024, 5:47 AM.
Tags
None
Referenced Files
F3193606: D13156.id43641.diff
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 2:29 AM
Unknown Object (File)
Fri, Oct 25, 2:50 PM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Thu, Oct 24, 7:01 PM
Unknown Object (File)
Thu, Oct 24, 6:45 PM
Unknown Object (File)
Thu, Oct 24, 3:44 PM
Unknown Object (File)
Sat, Oct 19, 2:33 PM
Subscribers

Details

Summary

ENG-8423.

Wrapping everything, processing message, and queueing on Tunnelbroker in one hook. In future this should also support Multimedia messages.

Depends on D13155

Test Plan

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 23 2024, 7:27 AM
tomek added inline comments.
lib/shared/dm-ops/process-dm-ops.js
212–213 ↗(On Diff #43613)

At this point, it doesn't work, because these aren't related in any way, but it is fixed in the next diff.

This revision is now accepted and ready to land.Aug 26 2024, 5:14 AM

A little confused reading this code, as it's unclear to me how supportsAutoRetry specs get sent

Included a couple nits since I'm already asking for a follow-up diff

lib/shared/dm-ops/process-dm-ops.js
216

Wondering why we have this !supportsAutoRetry condition here.

Is the idea that !supportsAutoRetry need to be manually sent when processAndSendDMOperation is called, whereas supportsAutoRetry gets automatically sent by some other mechanism?

If so, it would be good to add a code comment explaining this, and pointing to the other mechanism.

218

Nit: invert condition to reduce indentation

219

Nit