Paths

Table of Contentst

Differential D13155

[lib] implement action for sending DM messages
ClosedPublic
Actions

Authored by kamil on Aug 23 2024, 5:42 AM.

Tags

None

Referenced Files

	F3193605: D13155.id43640.diff
	Fri, Nov 8, 11:06 PM

	Unknown Object (File)
	Fri, Nov 8, 2:29 AM

	Unknown Object (File)
	Fri, Oct 25, 2:37 AM

	Unknown Object (File)
	Thu, Oct 24, 4:19 PM

	Unknown Object (File)
	Thu, Oct 24, 4:15 PM

	Unknown Object (File)
	Sat, Oct 19, 2:33 PM

	Unknown Object (File)
	Sat, Oct 19, 2:33 PM

	Unknown Object (File)
	Sat, Oct 19, 2:32 PM

View All 43 Files

Subscribers

Details

Reviewers

tomek
inka

Commits

rCOMM3ab02a144ee6: [lib] implement action for sending DM messages

Summary

Action dispatched when processing DM Operation, sucess will be dispatched when Tunnelbroker finished queueing messages.

SEND_DM_FAILED is not needed but implemented it this way to use dispatchActionPromise.

Depends on D13154

Test Plan

Test dispatching this action.

Note: This stack is tested end-to-end according to the process described here.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 23 2024, 5:42 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2024, 5:42 AM

kamil added inline comments.Aug 23 2024, 5:44 AM

lib/reducers/message-reducer.js
1878 ↗	(On Diff #43612)	I think we should remove the local entry when `remainingOutboundP2PMessageIDs.length === 0`.

kamil added a child revision: D13156: [lib] implement sending DM messages with tracking of success/failures.Aug 23 2024, 5:47 AM

Harbormaster completed remote builds in B31239: Diff 43612.Aug 23 2024, 5:59 AM

kamil published this revision for review.Aug 23 2024, 7:26 AM

kamil added inline comments.

lib/reducers/message-reducer.js
1893 ↗	(On Diff #43612)	this is used to show message in progress in UI when retrying

tomek accepted this revision.Aug 26 2024, 4:17 AM

tomek added inline comments.

lib/reducers/message-reducer.js
1865 ↗	(On Diff #43612)	We should create a `Set` from it before filtering.
1878 ↗	(On Diff #43612)	Agree
lib/types/redux-types.js
1596 ↗	(On Diff #43612)	Do you think it makes sense to rename this type?

This revision is now accepted and ready to land.Aug 26 2024, 4:17 AM

rename type
use Set
remove local entry after success

Harbormaster completed remote builds in B31265: Diff 43640.Aug 26 2024, 7:40 AM

Closed by commit rCOMM3ab02a144ee6: [lib] implement action for sending DM messages (authored by kamil). · Explain WhyAug 26 2024, 9:05 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM3ab02a144ee6: [lib] implement action for sending DM messages.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

message-reducer.js

59 lines

types/

15 lines

18 lines

Diff 43655

lib/reducers/message-reducer.js

Loading...

lib/types/dm-ops.js

Loading...

lib/types/redux-types.js

Loading...