[blob] Move HTTP request/response types to comm-lib
ClosedPublic
Actions

Authored by bartek on Oct 4 2024, 11:43 AM.

Details

Reviewers

kamil
varun
will

Commits

rCOMMb6f911a681b1: [blob] Move HTTP request/response types to comm-lib

Summary

These types can (and generally should) be shared with the BlobServiceClient living in the comm-lib.
Unified them with types existing in comm-lib so request and response structs are now shared between client and server

Depends on D13616

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 4 2024, 11:43 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptOct 4 2024, 11:43 AM

bartek added a child revision: D13618: [blob] Add DB method to query holders by prefix.Oct 4 2024, 11:46 AM

Harbormaster completed remote builds in B32079: Diff 44912.Oct 4 2024, 12:01 PM

bartek retitled this revision from [blob] Move BlobHashAndHolder struct to parent mod to [blob] Move HTTP request/response types to comm-lib.Oct 9 2024, 12:28 AM

bartek edited the summary of this revision. (Show Details)

Share types between client and server

Harbormaster completed remote builds in B32119: Diff 44989.Oct 9 2024, 12:49 AM

bartek published this revision for review.Oct 9 2024, 1:12 AM

bartek added a child revision: D13644: [comm-lib] Add remove_multiple_holders to Blob client.Oct 9 2024, 1:15 AM

bartek mentioned this in D13655: [lib] Add types for Blob Service requests and responses.Oct 9 2024, 2:13 AM

kamil accepted this revision.Oct 10 2024, 1:16 AM

kamil added inline comments.

shared/comm-lib/src/blob/types.rs
1 ↗	(On Diff #44989)	nit: can you standarize empty lines between structs and comments below? (if there is some pattern I don't see - sorry in advance, but it seems a bit messy)