Page MenuHomePhabricator

[backup-service] implement calling `FindUserID` RPC from Backup
ClosedPublic

Authored by kamil on Tue, Oct 29, 8:41 AM.
Tags
None
Referenced Files
F3372380: D13806.id45602.diff
Tue, Nov 26, 6:23 AM
F3371065: D13806.id45427.diff
Tue, Nov 26, 4:23 AM
Unknown Object (File)
Mon, Nov 25, 3:11 AM
Unknown Object (File)
Sat, Nov 16, 2:34 AM
Unknown Object (File)
Fri, Nov 15, 1:41 PM
Unknown Object (File)
Wed, Nov 13, 7:20 PM
Unknown Object (File)
Sat, Nov 9, 11:57 PM
Unknown Object (File)
Sat, Nov 9, 12:44 PM
Subscribers

Details

Summary

ENG-6145.

This is similar to other places in the codebase (here or here), there is also alternative where this code could be places in comm-lib but I prefer this, we can move it if needed.

Using is_valid_ethereum_address should be safe, we do the same on the client, and also it's not possible to create username which id valid ETH address.

Depends on D13805

Test Plan

tested later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Wed, Oct 30, 9:28 AM
varun added inline comments.
services/backup/src/error.rs
71 ↗(On Diff #45427)

what's this for?

This revision is now accepted and ready to land.Fri, Nov 1, 1:40 PM
bartek added inline comments.
services/backup/src/error.rs
71 ↗(On Diff #45427)

Let's name this IdentityClientError to be more precise