Page MenuHomePhabricator
Differential D13837

[native_rust_library] implement method to retrieve latest backup info
ClosedPublic
Actions

Authored by kamil on Thu, Oct 31, 5:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 5:45 PM
Unknown Object (File)
Thu, Nov 14, 10:55 PM
Unknown Object (File)
Mon, Nov 11, 7:44 AM
Unknown Object (File)
Sun, Nov 10, 11:36 PM
Unknown Object (File)
Sat, Nov 9, 7:31 PM
Unknown Object (File)
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 11:06 PM
Unknown Object (File)
Fri, Nov 8, 10:37 PM
View All 15 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info
Summary

ENG-6145.

This method will be used to get both backupID and userID.
There is some code duplication but later in the stack other function like retrieve_latest_siwe_backup_data or download_latest_backup_id are deprecated in favour of download_latest_backup_info (I had to somehow split this into diffs to make it easier for a review).
This function will be the main interface to get the backup latest info for both password and wallet users.

Depend on D13836

Test Plan

Tested in D13839

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Thu, Oct 31, 5:00 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Oct 31, 5:00 AM
kamil edited the summary of this revision. (Show Details)Thu, Oct 31, 5:01 AM
kamil updated this revision to Diff 45500.Thu, Oct 31, 5:04 AM

build

kamil added a parent revision: D13836: [backup-client] refactor `SIWEBackupData` type.Thu, Oct 31, 5:08 AM
kamil added a child revision: D13838: [CommCoreModule] expose method to retrieve latest backup info.Thu, Oct 31, 5:10 AM
Harbormaster failed remote builds in B32466: Diff 45499!Thu, Oct 31, 5:17 AM
Harbormaster completed remote builds in B32467: Diff 45500.Thu, Oct 31, 5:36 AM
kamil published this revision for review.Thu, Oct 31, 8:47 AM
kamil edited the test plan for this revision. (Show Details)
kamil mentioned this in D13808: [backup-service][backup-client] rename `username` -> `user_identifier`.Sun, Nov 3, 11:25 PM
bartek accepted this revision.Mon, Nov 4, 11:28 PM
bartek added inline comments.
native/native_rust_library/src/backup.rs
300–314 ↗(On Diff #45500)

Nit: alternatively to reduce nesting, but not sure if it's more readable

let siwe_backup_data_result = siwe_backup_msg
  .map(|msg_value| get_siwe_backup_data_from_msg(
      backup_id.clone(),
      siwe_backup_msg_value,
  ))
  .transpose(); // this should now be Result<Option<T>>

let siwe_backup_data = match siwe_backup_data_result {
  Ok(siwe_backup_data) => siwe_backup_data, // should be Option<T>
  Err(err) => {
    string_callback(err, promise_id, "".to_string());
    return;
  }
};
This revision is now accepted and ready to land.Mon, Nov 4, 11:28 PM
Closed by commit rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info (authored by kamil). · Explain WhyThu, Nov 7, 4:07 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM532c51fae374: [native_rust_library] implement method to retrieve latest backup info.

Revision Contents
Changeset List

PathSize
lib/
types/
14 lines
native/
native_rust_library/
src/
85 lines
3 lines

Diff 45668

View Options

lib/types/backup-types.js

Loading...
View Options

native/native_rust_library/src/backup.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...