Page MenuHomePhabricator

[CommCoreModule][native_rust_library] update downloading User Keys to support user identifier
Needs ReviewPublic

Authored by kamil on Thu, Oct 31, 8:28 AM.
Tags
None
Referenced Files
F3114561: D13849.diff
Thu, Oct 31, 8:28 PM
F3111363: D13849.id45516.diff
Thu, Oct 31, 1:50 PM
F3111336: D13849.id.diff
Thu, Oct 31, 1:50 PM
F3111327: D13849.diff
Thu, Oct 31, 1:50 PM

Details

Reviewers
varun
bartek
Summary

ENG-6145.

An alternative to this is to pass username and get BackupID from Rust — in terms of network calls, it should be the same. I implemented this because it required a lot fewer changes because it reused existing code.

Alternatively, we can download only backupID and read backupDataKey and backupLogDataKey (it should exist on primary always) to avoid downloading User Keys - but curious about @bartek's perspective as I don't fully remember why it was implemented that way,

  1. Deprecate download_latest_backup_id
  2. Update retrieveBackupKeys to have backupID

Depends on D13847

Test Plan

This is the final diff in the stack so testing this end-to-end:

  1. iOS and Android (I was using physical devices)
  2. username and wallet user
  3. testing restore similarly to link

TODO: test Secondary Auth Flow

Diff Detail

Repository
rCOMM Comm
Branch
backup-work-5
Lint
No Lint Coverage
Unit
No Test Coverage